1594342 - Update rust/libc crate to 0.2.66 (slice_deque fails to build on OpenBSD)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Landry Breuil (:gaston)]

m-c build is broken since 1581637, reported in slice-deque upstream too.

 0:11.72 error[E0432]: unresolved imports `libc::shmat`, `libc::shmctl`, `libc::shmdt`, `libc::shmget`, `libc::shmid_ds`, `libc::IPC_CREAT`, `libc::IPC_PRIVATE`, `libc::IPC_RMID`
 0:11.72  --> /home/landry/src/m-c/third_party/rust/slice-deque/src/mirrored/sysv.rs:4:34
 0:11.73   |
 0:11.73 4 |     c_int, c_void, mmap, munmap, shmat, shmctl, shmdt, shmget, shmid_ds,
 0:11.75   |                                  ^^^^^  ^^^^^^  ^^^^^  ^^^^^^  ^^^^^^^^ no `shmid_ds` in the root
 0:11.75   |                                  |      |       |      |
 0:11.75   |                                  |      |       |      no `shmget` in the root
 0:11.75   |                                  |      |       no `shmdt` in the root
 0:11.75   |                                  |      no `shmctl` in the root
 0:11.75   |                                  no `shmat` in the root
 0:11.75 5 |     sysconf, IPC_CREAT, IPC_PRIVATE, IPC_RMID, MAP_FAILED, MAP_PRIVATE,
 0:11.75   |              ^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^ no `IPC_RMID` in the root
 0:11.75   |              |          |
 0:11.75   |              |          no `IPC_PRIVATE` in the root
 0:11.75   |              no `IPC_CREAT` in the root
 0:11.75 help: a similar name exists in the module
 0:11.75   |
 0:11.75 4 |     c_int, c_void, mmap, munmap, shmat, sysctl, shmdt, shmget, shmid_ds,
 0:11.76   |                                         ^^^^^^
 0:11.76 help: a similar name exists in the module
 0:11.76   |
 0:11.76 5 |     sysconf, O_CREAT, IPC_PRIVATE, IPC_RMID, MAP_FAILED, MAP_PRIVATE,
 0:11.76   |              ^^^^^^^
 0:11.76 help: a similar name exists in the module
 0:11.76   |
 0:11.76 5 |     sysconf, IPC_CREAT, MAP_PRIVATE, IPC_RMID, MAP_FAILED, MAP_PRIVATE,
 0:11.76   |                         ^^^^^^^^^^^
 0:11.78 error[E0432]: unresolved import `libc::MAP_ANONYMOUS`
 0:11.78   --> /home/landry/src/m-c/third_party/rust/slice-deque/src/mirrored/sysv.rs:10:5
 0:11.78    |
 0:11.78 10 | use libc::MAP_ANONYMOUS;
 0:11.78    |     ^^^^^^^^^^^^^^^^^^^ no `MAP_ANONYMOUS` in the root
 0:12.78 error: aborting due to 2 previous errors
 0:12.78 For more information about this error, try `rustc --explain E0432`.
 0:13.11 error: Could not compile `slice-deque`.

Comment 1

[Landry Breuil (:gaston)]

Attachment: add missing methods to libc crate

with this horrible hack to libc crate my build goes further, but going the shm* route might not be the better option.. as shm syscalls are prevented by sandboxing. Oh well, will bring that in upstream rust libc repo, then keep this bug for the libc crate upgrade.

Comment 2

[Landry Breuil (:gaston)]

https://github.com/rust-lang/libc/issues/1585 was merged in rust libc, now pending a crate release to ask for the in-tree libc to be updated..

Comment 3

[Landry Breuil (:gaston)]

Updating the libc create would be nice, but with https://github.com/gnzlbg/slice_deque/issues/78 landed in slice_deque itself we dont need the shm stuff anymore on OpenBSD, so that wont break with pledge sandboxing.

So is it possible to update slice_deque crate once its been released ?

Comment 4

[Landry Breuil (:gaston)]

dragana, heycam, since http3 support in bug #1581637 broke tier-3 build, can you take care of what's needed to upgrade slide_deque in third_party/rust/slice_deque ? i dont know the process involved.. thanks !

Comment 5

[Dragana Damjanovic [:dragana]]

(In reply to Landry Breuil (:gaston) from comment #4)

dragana, heycam, since http3 support in bug #1581637 broke tier-3 build, can you take care of what's needed to upgrade slide_deque in third_party/rust/slice_deque ? i dont know the process involved.. thanks !

We were planning to remove dependency on slice-deque, but I need to check timeline for that.

Comment 6

[Dragana Damjanovic [:dragana]]

Andy is working on removing slice-deque dependency.

Comment 7

[Andy Grover [:grover]]

Yep. This is fixed upstream in neqo-transport 0.1.7 but importing this is currently blocked by bug 1600792.

Comment 8

[Landry Breuil (:gaston)]

[Tracking Requested - why for this release]:
this slice-deque dependency removal should be a candidate for beta backport, since 72.0b1 now fails to build on OpenBSD. sigh :)

Comment 9

[Julien Cristau [:jcristau]]

I don't think I need to track this.

Comment 10

[Mike Hommey [:glandium]]

Bug 1655929 upgraded to libc 0.2.74.