Closed Bug 1594342 Opened 4 years ago Closed 4 years ago

Update rust/libc crate to 0.2.66 (slice_deque fails to build on OpenBSD)

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox71 unaffected, firefox72- wontfix, firefox73 wontfix, firefox81 fixed)

RESOLVED FIXED
Tracking Status
firefox71 --- unaffected
firefox72 - wontfix
firefox73 --- wontfix
firefox81 --- fixed

People

(Reporter: gaston, Assigned: gaston)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

m-c build is broken since 1581637, reported in slice-deque upstream too.

 0:11.72 error[E0432]: unresolved imports `libc::shmat`, `libc::shmctl`, `libc::shmdt`, `libc::shmget`, `libc::shmid_ds`, `libc::IPC_CREAT`, `libc::IPC_PRIVATE`, `libc::IPC_RMID`
 0:11.72  --> /home/landry/src/m-c/third_party/rust/slice-deque/src/mirrored/sysv.rs:4:34
 0:11.73   |
 0:11.73 4 |     c_int, c_void, mmap, munmap, shmat, shmctl, shmdt, shmget, shmid_ds,
 0:11.75   |                                  ^^^^^  ^^^^^^  ^^^^^  ^^^^^^  ^^^^^^^^ no `shmid_ds` in the root
 0:11.75   |                                  |      |       |      |
 0:11.75   |                                  |      |       |      no `shmget` in the root
 0:11.75   |                                  |      |       no `shmdt` in the root
 0:11.75   |                                  |      no `shmctl` in the root
 0:11.75   |                                  no `shmat` in the root
 0:11.75 5 |     sysconf, IPC_CREAT, IPC_PRIVATE, IPC_RMID, MAP_FAILED, MAP_PRIVATE,
 0:11.75   |              ^^^^^^^^^  ^^^^^^^^^^^  ^^^^^^^^ no `IPC_RMID` in the root
 0:11.75   |              |          |
 0:11.75   |              |          no `IPC_PRIVATE` in the root
 0:11.75   |              no `IPC_CREAT` in the root
 0:11.75 help: a similar name exists in the module
 0:11.75   |
 0:11.75 4 |     c_int, c_void, mmap, munmap, shmat, sysctl, shmdt, shmget, shmid_ds,
 0:11.76   |                                         ^^^^^^
 0:11.76 help: a similar name exists in the module
 0:11.76   |
 0:11.76 5 |     sysconf, O_CREAT, IPC_PRIVATE, IPC_RMID, MAP_FAILED, MAP_PRIVATE,
 0:11.76   |              ^^^^^^^
 0:11.76 help: a similar name exists in the module
 0:11.76   |
 0:11.76 5 |     sysconf, IPC_CREAT, MAP_PRIVATE, IPC_RMID, MAP_FAILED, MAP_PRIVATE,
 0:11.76   |                         ^^^^^^^^^^^
 0:11.78 error[E0432]: unresolved import `libc::MAP_ANONYMOUS`
 0:11.78   --> /home/landry/src/m-c/third_party/rust/slice-deque/src/mirrored/sysv.rs:10:5
 0:11.78    |
 0:11.78 10 | use libc::MAP_ANONYMOUS;
 0:11.78    |     ^^^^^^^^^^^^^^^^^^^ no `MAP_ANONYMOUS` in the root
 0:12.78 error: aborting due to 2 previous errors
 0:12.78 For more information about this error, try `rustc --explain E0432`.
 0:13.11 error: Could not compile `slice-deque`.

with this horrible hack to libc crate my build goes further, but going the shm* route might not be the better option.. as shm syscalls are prevented by sandboxing. Oh well, will bring that in upstream rust libc repo, then keep this bug for the libc crate upgrade.

Assignee: nobody → landry
Priority: -- → P1
Whiteboard: [necko-triaged]
Component: Networking: HTTP → General
Priority: P1 → --
Product: Core → Firefox Build System
Whiteboard: [necko-triaged]

https://github.com/rust-lang/libc/issues/1585 was merged in rust libc, now pending a crate release to ask for the in-tree libc to be updated..

Summary: slice_deque fails to build on OpenBSD → Update rust/libc crate to 0.2.66 (slice_deque fails to build on OpenBSD)

Updating the libc create would be nice, but with https://github.com/gnzlbg/slice_deque/issues/78 landed in slice_deque itself we dont need the shm stuff anymore on OpenBSD, so that wont break with pledge sandboxing.

So is it possible to update slice_deque crate once its been released ?

dragana, heycam, since http3 support in bug #1581637 broke tier-3 build, can you take care of what's needed to upgrade slide_deque in third_party/rust/slice_deque ? i dont know the process involved.. thanks !

Flags: needinfo?(dd.mozilla)
Flags: needinfo?(cam)

(In reply to Landry Breuil (:gaston) from comment #4)

dragana, heycam, since http3 support in bug #1581637 broke tier-3 build, can you take care of what's needed to upgrade slide_deque in third_party/rust/slice_deque ? i dont know the process involved.. thanks !

We were planning to remove dependency on slice-deque, but I need to check timeline for that.

Andy is working on removing slice-deque dependency.

Flags: needinfo?(dd.mozilla)

Yep. This is fixed upstream in neqo-transport 0.1.7 but importing this is currently blocked by bug 1600792.

[Tracking Requested - why for this release]:
this slice-deque dependency removal should be a candidate for beta backport, since 72.0b1 now fails to build on OpenBSD. sigh :)

I don't think I need to track this.

Bug 1655929 upgraded to libc 0.2.74.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Flags: needinfo?(cam)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: