1594914 - mach - python-test compatibility for python3

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task, P3)

Description

[Edwin Takahashi (:egao | infrequent contributor)]

Enable python3 compatibility for ./mach python-test.

To complete fully, this task will require multiple sub-tasks to be completed:

• migration of all dependencies to be python3 compatible
• all tests of dependencies run on python3 in addition to python2.7

Once the prerequisites are complete, I envision the following tasks:

• migrate syntax to python3
• enable and pass tests on python3

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Hamzah Akhtar]

Attachment: Bug 1594914 - /mach python-test

Comment 3

[Hamzah Akhtar]

Attachment: Bug 1594914 - Convert mach python-test to run with python 3

https://phabricator.services.mozilla.com/D77866

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19269e470c71
Convert mach python-test to run with python 3 r=gbrown

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset 19269e470c71 (Bug 1594914) for causing bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e50941c3894af1e41e512f9b6f9b241f59f2f87b

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=build&tochange=e50941c3894af1e41e512f9b6f9b241f59f2f87b&fromchange=264dd8a5f9c8ed2be7c8183ff9d52932d9f03926&selectedTaskRun=ZmK0qN3HRmy2M8cn-l8r8g.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309024902&repo=autoland&lineNumber=58870

Update - Also seeing these valgrid bustages which look related:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309046114&repo=autoland&lineNumber=58892

Comment 6

[Mike Hommey [:glandium]]

The failures on the first landing were from running python tests during make check, which we don't do anymore as of bug 1655111, so this can reland.

Comment 7

[Geoff Brown [:gbrown]]

Yes! ...except for some new mozbuild failures, only on py2/osx:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=efc3b4ed78b0ad0c4dd3cfc123da83b5899e1793

I'll have a look today...maybe just disable on py2/osx again?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a274e08c3a77
Convert mach python-test to run with python 3 r=gbrown

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a274e08c3a77

Comment 10

[Mitchell Hentges [:mhentges] 🦀]

Comment on attachment 9153524 [details]
Bug 1594914 - Convert mach python-test to run with python 3

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to uplift https://phabricator.services.mozilla.com/D88296, otherwise the non-pipenv test runner runs with Python 2, and that fails.
• User impact if declined: None
• Fix Landed on Version: 81
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
• String or UUID changes made by this patch:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9153524 [details]
Bug 1594914 - Convert mach python-test to run with python 3

Needed to better support running mach on newer macOS releases. Approved for 78.8esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/2e5fc3e1f082