Remove w3c-css/received/css-multicol reftests
Categories
(Core :: Layout, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
Comment hidden (obsolete) |
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Bug 1594737 comment 2 provides an analysis on why it is OK to remove
css-multicol reftests.
The only manual modification in this patch is removing
os.path.join("css-multicol")
in import-tests.py. Others parts are
generated by running import-tests.py on a wpt repository with commit
15f199c91a72b0d51bf0a12b3b77827ecb5051ff.
Assignee | ||
Comment 6•5 years ago
|
||
I think this points out that:
- we have a bunch of old
skip
andfuzzy(0-X,0-Y)
annotations that ought to be cleaned up (since it would increase our test coverage)
Right, we should remove those annotations when investigating other css modules.
- we have a bunch of
prefs: [layout.css.column-span.enabled:true]
in WPT ini files that should probably be cleaned up soon (although maybe not yet)
The pref can be removed in bug 1499281 after column-span reaches the release channel in 71.
Comment 8•5 years ago
|
||
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=277781054&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/4a51a464d8efabde6a41af89fbb6aace77613f98
Assignee | ||
Comment 9•5 years ago
|
||
Hmm, my patch is unlikely to cause dom/tests/reftest/bug453105.html
fail because it just removes a lot of reftests, without changing any gecko behavior.
Assignee | ||
Comment 10•5 years ago
|
||
Pushed a try, and it seems bug453105.html
on Android becomes nearly perma-orange for 1 pixel diff for some unknown reason, though some R2 runs did pass on Android 7.0 x86-64 opt
. I've filed bug 1600534 for this, and will add a fuzzy-if
for bug453105.html
.
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
bugherder |
Description
•