Closed Bug 1594937 Opened 4 months ago Closed 3 months ago
Remove w3c-css/received/css-multicol reftests
39.82 KB, patch
|Details | Diff | Splinter Review|
47 bytes, text/x-phabricator-request
|Details | Review|
Note that this patch is used to analyze the fail/pass state in w3c-css/css-multicol, not for check-in. The following test are annotated "fails-if(!OSX) random-if(OSX)" due to not load Ahem properly (a shortcoming in import-tests.py). The can be fixed by manually adding proper <style> to load Ahem. multicol-count-002.xht multicol-inherit-003.xht multicol-rule-001.xht multicol-rule-002.xht multicol-rule-px-001.xht multicol-rule-stacking-001.xht multicol-shorthand-001.xht multicol-span-all-003.xht multicol-width-count-002.xht multicol-width-negative-001.xht The rest of the failed tests match the state in wpt. Either they have ini marked as failures in wpt, or they're fixed in wpt. Here a try run of this patch. https://treeherder.mozilla.org/#/jobs?repo=try&collapsedPushes=532734&revision=d4d2f9c2cb49a2366a80ebf5472e63c63ccf42f0 multicol-span-all-block-sibling-003.xht fails on Windows because of anti-alias issue. wpt doesn't have the same problem, but I think it's OK.
Attachment #9107378 - Attachment is obsolete: true
Comment on attachment 9107379 [details] [diff] [review] Remove fuzzy notation and add <style> to properly load Ahem for received multicol reftests. David, if the analysis in comment 2 looks reasonable, I'll write a patch to remove `received/css-multicol`
Attachment #9107379 - Flags: feedback?(dbaron)
Comment on attachment 9107379 [details] [diff] [review] Remove fuzzy notation and add <style> to properly load Ahem for received multicol reftests. This makes sense. I think this points out that: * we have a bunch of old `skip` and `fuzzy(0-X,0-Y)` annotations that ought to be cleaned up (since it would increase our test coverage) * we have a bunch of `prefs: [layout.css.column-span.enabled:true]` in WPT ini files that should probably be cleaned up soon (although maybe not yet)
Attachment #9107379 - Flags: feedback?(dbaron) → feedback+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/148081b861c8 Remove w3c-css/received/css-multicol reftests. r=dbaron
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f4f9195bd628 Remove w3c-css/received/css-multicol reftests. r=dbaron
You need to log in before you can comment on or make changes to this bug.