1595014 - Part of search suggestions remain with WR partial present

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Sotaro Ikeda [:sotaro]]

When WR partial present is enabled. There is a case that part of rendering is not updated correctly. Old rendering remained.

Steps to reproduce:

Reproduce:

• [1] Enable WebRender and partial present
  • pref gfx.webrender.all: true
  • pref gfx.webrender.max-partial-present-rects: 1
• [2] Restart Firefox
• [3] Type text in search bar
• [4] Deselect/unfocus search bar by clicking bottom of content area

-Expected result
Search bar go way.

-Actual result
Bottom of search bar remained.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: screenshot

Comment 2

[Sotaro Ikeda [:sotaro]]

:gw, do you have an idea about how it could happen?

Comment 3

[Glenn Watson [:gw]]

I can't reproduce this on my local win10 machine built against current m-c.

Does it happen for you every time or only intermittently? Any other ideas on how I could reproduce on my machine?

It's probably worth also logging out the dirty rect(s) that are being supplied by WR each frame and see if they seem to match what you would expect.

A screen capture with gfx.webrender.debug.picture-caching might also offer some clues. In particular, does the display list for the search results come from the content or parent process? It is part of the main WR instance, is that right (i.e. not a separate window + WR instance)?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Jessie [:jbonisteel] pls NI]

No idea if this helps, but I once had a bug like that when I still had document splitting enabled.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1595014 - Make dirty rects are invalid when old tiles were dropped

Comment 7

[Sotaro Ikeda [:sotaro]]

composite_simple() calculates combined dirty rect from all tile's dirty rect. But the combined dirty rect becomes invalid when there is a tile that is not used that was used before.
https://searchfox.org/mozilla-central/rev/7e92a667e3829831c31e8d46aefe7ef67ad5be1c/gfx/wr/webrender/src/renderer.rs#4292

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e08016b3d0a
Make dirty rects are invalid when old tiles were dropped r=gw

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8e08016b3d0a

Comment 10

[Asif Youssuff]

Attachment: firefox.png

This doesn't seem fixed for me. See screenshot.

Comment 11

[Asif Youssuff]

Attachment: wr-capture.8.zip

Attaching a capture of when it happened.

Comment 12

[Sotaro Ikeda [:sotaro]]

I confirmed that the problem happened. Though, teproducing the problem became more difficult than before.

Comment 13

[Sotaro Ikeda [:sotaro]]

It seemed that the problem seemed to happen by a different cause than Attachment 9126005 [details]. Attachment 9126005 [details] addressed a problem during dropping tiles.

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1595014 - Make dirty rects are invalid when all tiles of retained_tiles are not re-used

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed941d35569d
Make dirty rects are invalid when all tiles of retained_tiles are not re-used r=gw

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ed941d35569d

Comment 17

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 72.0a1 (2019.11.08) on Win 10 x64.
I can confirm it is fixed, I verified using Firefox 75.0b7, on Windows 10 x64.