1595058 - An "Unknown ping type" error is displayed instead of the "impression" and "click" events for the "Pre-Trailhead Triplets" cards

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 72.0a1 - Build ID: 20191107215315

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Steps to reproduce]:

1. Create a new Firefox profile, but DO NOT open it.
2. Navigate to the local Profiles folder (eg. C:\Users\user\AppData\Roaming\Mozilla\Firefox\Profiles) and open the newly created profile folder.
3. Open times.json in a text editor and change the created date to "1559530800000".
4. Save the file and open the browser with the newly created profile.
5. Without opening new tabs or windows install the latest version of the "remote-settings-devtools" from here.
6. Click the "Remote Settings Devtools" toolbar button and select the "Stage" environment.
7. Click the "Force sync" button on the right of the "main/whats-new-panel" option. (you might need to Clear Local Data first)
8. Restart the browser and navigate to the "about:config" page
9. Set the "browser.ping-centre.log" pref's value to "true" and open the "Browser Console".
10. Open a new tab and observe the pings displayed in the "Browser Console".

[Expected result]:

• The "impression" telemetry ping for the "PRETRAILHEAD" Triplets is displayed.

[Actual result]:

• An "Unknown ping type for ASRouter telemetry" error is displayed instead.

[Notes]:

• This issue is also reproducible if the button from any of the "Pre-Trailhead Triplets" cards is clicked.
• This issue is not reproducible if the cards are dismissed. In this case the following ping is displayed in the "Browser Console":
  "TELEMETRY PING (STRUCTURED INGESTION): {"locale":"en-US","version":"72.0a1","release_channel":"nightly","message_id":"PRETRAILHEAD_CARD_1,PRETRAILHEAD_CARD_2,PRETRAILHEAD_CARD_3","source":"onboarding-cards","event":"DISMISS","id":"onboarding-cards","addon_version":"20191107215315","client_id":"0e490dee-09d6-6d4b-b165-c73e26a1c5a0","shield_id":"activity-stream-extended-triplets-v2-1581912:control;"}".
• Attached a screen recording of the issue.

Comment 1

[Marius Coman [:mcoman], Ecosystem QA]

@Ed, could you please take a look over this issue?

Comment 2

[Ed Lee :Mardak]

Bug 1585147 landed in bug 1594541 export "at the same time" and only affects nightly 72. It added this check to only allow a specific list of actions/pings it seems ?

https://github.com/mozilla/activity-stream/commit/147fd74cecd71ed2f7f148475b356604786cd0a7#diff-94703ac9d8be70bee8f84ca6c6ff1956R703-R705

The fix for nightly would be to add whats-new-panel_user_event to the switch/case ?

Comment 3

[Ed Lee :Mardak]

There was a small window where a nightly build was built with pretrailhead but without the export:

https://archive.mozilla.org/pub/firefox/nightly/2019/11/2019-11-07-09-49-05-mozilla-central/

Could you test with that build to see if telemetry works?

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have retested this issue using the Nightly build from above and I can confirm that the telemetry pings for the "impression" and "click" events are successfully displayed in the "Browser Console".

Comment 5

[Liz Henry (:lizzard)]

We'll likely need a fix for this for 70 uplift as well once the work in bug 1594125 gets uplifted.

Comment 6

[Ed Lee :Mardak]

The regressing bug 1585147 is only on nightly and won't be uplifted to 70 release

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5373

Comment 8

[Nan Jiang [:nanj]]

Attachment: Bug 1595058 - add a new ping type for pre-trailhead

The pre-trailhead triplets, added in bug 1594125 through the remote whats-new-panel provider, serve as another onboarding like messages for AS Router.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/452480b6db9c
add a new ping type for pre-trailhead r=Mardak

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/452480b6db9c

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (72.0a1 Build ID - 20191114055112) installed, on Windows 10 x64, Arch Linux and Mac 10.15.1. Now, the telemetry pings are successfully displayed in the "Browser Console".