1595124 - Page style actor throws errors about `styleMenu is undefined`, probably because e.g. thumbnail service can load pages with page styles in non-browser windows

Status: RESOLVED DUPLICATE of bug 1595370

(Firefox :: Menus, defect)

Description

[:Gijs (out for now; he/him)]

https://searchfox.org/mozilla-central/rev/b2b0077c2e6a516a76bf8077d6f0237c58f5959a/browser/actors/PageStyleParent.jsm#21,30,33

gPageStyleMenu only exists in browser windows, and browsing contexts aren't necessarily in browser windows.

Comment 1

[:Gijs (out for now; he/him)]

James, can you poke at this too? Sorry!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Run ./mach test browser_thumbnails_bg_image_capture.js
2. Look at the console output

ER:

No error messages about PageStyle

AR:

Errors abound. Here's a test run log:

 0:03.84 TEST_START: toolkit/components/thumbnails/test/browser_thumbnails_bg_image_capture.js
 0:04.11 INFO Console message: [JavaScript Error: "The character encoding of the plain text document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the file needs to be declared in the transfer protocol or file needs to use a byte order mark as an encoding signature." {file: "data:text/plain," line: 0}]
 0:06.64 PASS Should have the right failure reason -
 0:06.68 GECKO(31991) JavaScript error: resource:///actors/PageStyleParent.jsm, line 33: TypeError: styleMenu is undefined
 0:06.69 GECKO(31991) JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
 0:06.68 INFO Console message: [JavaScript Error: "TypeError: styleMenu is undefined" {file: "resource:///actors/PageStyleParent.jsm" line: 33}]
 0:06.68 INFO Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
 0:06.70 GECKO(31991) JavaScript error: resource:///actors/PageStyleParent.jsm, line 30: TypeError: styleMenu is undefined
 0:06.70 GECKO(31991) JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
 0:06.69 INFO Console message: [JavaScript Error: "TypeError: styleMenu is undefined" {file: "resource:///actors/PageStyleParent.jsm" line: 30}]
 0:06.69 INFO Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
 0:09.21 PASS page-thumbnail created for http://mochi.test:8888/browser/toolkit/components/thumbnails/test/sample_image_red_1920x1080.jpg -
 0:09.21 PASS The image thumbnail should exist after capture -
 0:09.21 PASS The thumbnail should have the right width -
 0:09.21 PASS The thumbnail should have the right height -
 0:09.22 PASS The thumbnail should have the right color -
 0:09.23 GECKO(31991) JavaScript error: resource:///actors/PageStyleParent.jsm, line 33: TypeError: styleMenu is undefined
 0:09.24 GECKO(31991) JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
 0:09.23 INFO Console message: [JavaScript Error: "TypeError: styleMenu is undefined" {file: "resource:///actors/PageStyleParent.jsm" line: 33}]
 0:09.23 INFO Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
 0:09.65 GECKO(31991) JavaScript error: resource:///actors/PageStyleParent.jsm, line 30: TypeError: styleMenu is undefined
 0:09.65 GECKO(31991) JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
 0:09.65 INFO Console message: [JavaScript Error: "TypeError: styleMenu is undefined" {file: "resource:///actors/PageStyleParent.jsm" line: 30}]
 0:09.65 INFO Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
 0:12.76 PASS page-thumbnail created for http://mochi.test:8888/browser/toolkit/components/thumbnails/test/sample_image_green_1024x1024.jpg -
 0:12.76 PASS The image thumbnail should exist after capture -
 0:12.76 PASS The thumbnail should have the right width -
 0:12.76 PASS The thumbnail should have the right height -
 0:12.76 PASS The thumbnail should have the right color -
 0:12.78 GECKO(31991) JavaScript error: resource:///actors/PageStyleParent.jsm, line 33: TypeError: styleMenu is undefined
 0:12.78 GECKO(31991) JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
 0:12.78 INFO Console message: [JavaScript Error: "TypeError: styleMenu is undefined" {file: "resource:///actors/PageStyleParent.jsm" line: 33}]
 0:12.78 INFO Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
 0:13.21 GECKO(31991) JavaScript error: resource:///actors/PageStyleParent.jsm, line 30: TypeError: styleMenu is undefined
 0:13.21 GECKO(31991) JavaScript error: , line 0: NS_ERROR_UNEXPECTED:
 0:13.20 INFO Console message: [JavaScript Error: "TypeError: styleMenu is undefined" {file: "resource:///actors/PageStyleParent.jsm" line: 30}]
 0:13.20 INFO Console message: [JavaScript Error: "NS_ERROR_UNEXPECTED: "]
 0:16.29 PASS page-thumbnail created for http://mochi.test:8888/browser/toolkit/components/thumbnails/test/sample_image_blue_300x600.jpg -
 0:16.30 PASS The image thumbnail should exist after capture -
 0:16.30 PASS The thumbnail should have the right width -
 0:16.30 PASS The thumbnail should have the right height -
 0:16.30 PASS The thumbnail should have the right color -
 0:16.30 GECKO(31991) MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
 0:16.31 GECKO(31991) MEMORY STAT | vsize 7580MB | residentFast 290MB | heapAllocated 98MB
 0:16.30 TEST_END: Test OK. Subtests passed 16/16. Unexpected 0
 0:16.32 INFO checking window state
 0:17.48 GECKO(31991) Completed ShutdownLeaks collections in process 31997
 0:17.48 GECKO(31991) Completed ShutdownLeaks collections in process 31998
 0:17.48 GECKO(31991) Completed ShutdownLeaks collections in process 31996
 0:17.50 GECKO(31991) Completed ShutdownLeaks collections in process 31995
 0:17.51 GECKO(31991) Completed ShutdownLeaks collections in process 31994
 0:17.77 GECKO(31991) Completed ShutdownLeaks collections in process 31991
 0:17.77 INFO TEST-START | Shutdown
 0:17.77 INFO Browser Chrome Test Summary
 0:17.77 INFO Passed:  16
 0:17.77 INFO Failed:  0
 0:17.77 INFO Todo:    0
 0:17.77 INFO Mode:    e10s
 0:17.77 INFO *** End BrowserChrome Test Results ***
 0:17.93 GECKO(31991) 1573244000467	Marionette	TRACE	Received observer notification xpcom-will-shutdown
 0:17.93 GECKO(31991) 1573244000467	Marionette	INFO	Stopped listening on port 2828
 0:17.93 GECKO(31991) 1573244000467	Marionette	DEBUG	Remote service is inactive
 0:18.32 Main app process: exit 0
 0:18.32 INFO runtests.py | Application ran for: 0:00:17.394698
 0:18.32 INFO zombiecheck | Reading PID log: /var/folders/bq/n5qs5f650bl7kmj4h_fqsw2m0000gn/T/tmp_hzTcWpidlog
 0:18.32 INFO ==> process 31991 launched child process 31993
 0:18.32 INFO ==> process 31991 launched child process 31994
 0:18.32 INFO ==> process 31991 launched child process 31995
 0:18.32 INFO ==> process 31991 launched child process 31996
 0:18.32 INFO ==> process 31991 launched child process 31997
 0:18.32 INFO ==> process 31991 launched child process 31998
 0:18.32 INFO ==> process 31991 launched child process 32001
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 32001
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 31993
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 31994
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 31995
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 31996
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 31997
 0:18.32 INFO zombiecheck | Checking for orphan process with PID: 31998
 0:18.32 INFO Stopping web server
 0:18.34 INFO Stopping web socket server
 0:18.36 INFO Stopping ssltunnel
 0:18.38 WARNING leakcheck | refcount logging is off, so leaks can't be detected!
 0:18.38 INFO runtests.py | Running tests: end.
 0:18.42 INFO Buffered messages finished
TEST-INFO | checking window state
Browser Chrome Test Summary
	Passed: 16
	Failed: 0
	Todo: 0
	Mode: e10s
*** End BrowserChrome Test Results ***
 0:18.42 INFO Buffered messages finished
 0:18.42 SUITE_END
 0:18.42
Overall Summary
===============

Comment 3

[:Gijs (out for now; he/him)]

Looks like :tnikkel independently found and filed this and put up a patch at bug 1595370, so duping there.