1557118 - Support group in registerWindowActor

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Neil Deakin]

This is used by some actors defined in BrowserGlue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Neil Deakin]

Bug 1610141 describes one case where this is needed. There are others I've found while porting some actors.

Legacy actors support a group flag which limits the actors from being applied to browser elements that don't have a matching 'messagemanagergroup'. Some specific groups that need to be distinguished:

• 'browsers' - the main browser elements in the window
• 'sidebar' - content loaded in a sidebar. Some actors should not apply here that would apply in other places.
• 'extensions' - content loaded in an extension.
• 'test' - the findbar, for example, is currently tested within some chrome tests that embed <browser type="content">. The actor would need to be created here.

Comment 3

[Neil Deakin]

Attachment: Bug 1557118, add support for filtering actor creation based on the messagemanagergroup attribute set on browser elements, r=farre

Comment 4

[Neil Deakin]

Attachment: Bug 1557118, test to check filtering actor creation based on the messagemanagergroup attribute, r=farre

Depends on D68780

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/986051b690e9
add support for filtering actor creation based on the messagemanagergroup attribute set on browser elements, r=farre

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb7b5139b10b
test to check filtering actor creation based on the messagemanagergroup attribute, r=farre

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/986051b690e9
https://hg.mozilla.org/mozilla-central/rev/bb7b5139b10b

Comment 8

[:Gijs (he/him)]

Is there a metabug to audit the existing actors that were converted and might benefit from having this property added? The page style actor from bug 1595370 is definitely one, but I bet there are others.