Closed Bug 1595135 Opened 5 years ago Closed 5 years ago

Perma browser_thumbnails_bg_image_capture.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. when Gecko 72 merges to Beta on 2019-12-02

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 + verified

People

(Reporter: NarcisB, Assigned: mconley)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1595135 - Make thumbnail tests run more quickly. r?Mardak
47 bytes, text/x-phabricator-request
Details | Review
Bug 1595135 - Make sure that we do thumbnail captures soon after requesting them in tests instead of waiting for an idle callback. r?Mardak
47 bytes, text/x-phabricator-request
Details | Review

[Tracking Requested - why for this release]:

Central as Beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=275336832&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=f63a1e84de8c26f2dd965982304738b401eabfdd&searchStr=bc

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275336832&repo=try&lineNumber=7398

[task 2019-11-08T15:49:38.603Z] 15:49:38 INFO - TEST-PASS | toolkit/components/thumbnails/test/browser_thumbnails_bg_image_capture.js | The thumbnail should have the right color -
[task 2019-11-08T15:49:38.604Z] 15:49:38 INFO - Leaving test bound thumbnails_bg_image_capture
[task 2019-11-08T15:49:38.604Z] 15:49:38 INFO - Buffered messages finished
[task 2019-11-08T15:49:38.604Z] 15:49:38 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/thumbnails/test/browser_thumbnails_bg_image_capture.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
[task 2019-11-08T15:49:38.604Z] 15:49:38 INFO - GECKO(11790) | MEMORY STAT | vsize 2869MB | residentFast 272MB | heapAllocated 96MB
[task 2019-11-08T15:49:38.605Z] 15:49:38 INFO - TEST-OK | toolkit/components/thumbnails/test/browser_thumbnails_bg_image_capture.js | took 48767ms

Flags: needinfo?(mconley)
Assignee: nobody → mconley
Flags: needinfo?(mconley)
Iteration: --- → 72.2 - Nov 4 - 17
Priority: -- → P1
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d7640ffbf2a
Make thumbnail tests run more quickly. r=Mardak
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f09b92421976
Backed out changeset 5d7640ffbf2a for causing bc failures in toolkit/components/thumbnails CLOSED TREE

This is so that we can ensure that the captures actually occur during the lifetime
of the test.

Depends on D52426

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63a9116eca76
Make thumbnail tests run more quickly. r=Mardak
https://hg.mozilla.org/integration/autoland/rev/4ddb439ba4c1
Make sure that we do thumbnail captures soon after requesting them in tests instead of waiting for an idle callback. r=Mardak
Flags: needinfo?(mconley)

https://hg.mozilla.org/mozilla-central/rev/63a9116eca76
https://hg.mozilla.org/mozilla-central/rev/4ddb439ba4c1

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: