1591495 - Update thumbnailer tests to use modern primitives

Status: RESOLVED FIXED

(Firefox :: General, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

The thumbnailer tests use an old-school handrolled TestRunner thing with yield and generators, and a bunch of helpers that have been superceded by stuff in BrowserTestUtils.

This is blocking us from getting bug 1576911 landed, since those tests are failing because they're using those old flake-y primitives. We shouldn't update those old mechanisms, we should just wholesale more over to more modern primitives.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1591495 - Disable browser_thumbnails_storage_migrate3.js. r?Gijs

This test is race-y, and doesn't actually ensure that the migration has completed
before doing its checks.

When I modified the test to wait for the migration to complete, the test actually
failed. Which isn't great news.

The good news, however, is that the migration took place back in Firefox 21, and
so we can probably remove all of the migration code now.

I'm disabling the test for now, and filed bug 1592079 to remove the migration code
and test completely.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1591495 - Update thumbnailer test utility functions. r?Gijs

Significantly, we remove the TestRunner stuff since we have nice things like
add_task now.

Depends on D50850

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1591495 - Update thumbnail tests to use more modern primitives, like add_task. r?Gijs

Depends on D50851

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14014646834b
Disable browser_thumbnails_storage_migrate3.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/567490296c0e
Update thumbnailer test utility functions. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/0a35639905ee
Update thumbnail tests to use more modern primitives, like add_task. r=Gijs

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14014646834b
https://hg.mozilla.org/mozilla-central/rev/567490296c0e
https://hg.mozilla.org/mozilla-central/rev/0a35639905ee

Comment 6

[Patrick (he/him)]

This bug appears to have caused a regression - https://bugzilla.mozilla.org/show_bug.cgi?id=1604780