Closed Bug 1595190 Opened 5 years ago Closed 4 years ago

Fix intermittent hangs in browser/components/uitour/test/

Categories

(Firefox :: Tours, task, P3)

task

Tracking

()

RESOLVED WORKSFORME
Fission Milestone M7

People

(Reporter: mccr8, Unassigned)

References

(Blocks 2 open bugs)

Details

In bug 1594878, I made the browser/components/uitour/test/ directory preserve processes, in an attempt to fix frequent intermittent hangs. We should figure out what the actual source of those hangs is, fix it, then remove the pref set of dom.ipc.keepProcessesAlive.webIsolated.perOrigin for that directory.

Fission Milestone: --- → M4.1

Andrew, do you think these intermittent shutdown hangs need to block the Fission mochitests milestone (M4.1)?

Flags: needinfo?(continuation)

The workaround of reusing Fission processes seems to have stopped the issue from showing up on TreeHerder, and hasn't popped up in a while, so I think we don't need to track this for M4.1 any more.

I am concerned that there's some real hang issues related to this that we might see in the wild, but I think we can ignore that until we get telemetry or whatever showing it. But if we do, it would be good to keep these issues we've seen in testing in mind.

Flags: needinfo?(continuation)

(In reply to Andrew McCreight [:mccr8] from comment #2)

The workaround of reusing Fission processes seems to have stopped the issue from showing up on TreeHerder, and hasn't popped up in a while, so I think we don't need to track this for M4.1 any more.

I am concerned that there's some real hang issues related to this that we might see in the wild, but I think we can ignore that until we get telemetry or whatever showing it. But if we do, it would be good to keep these issues we've seen in testing in mind.

Thanks. Tracking for Fission riding the trains to Beta (M7) after we see how much of a problem this is with more users.

Fission Milestone: M4.1 → M7
Priority: -- → P3

This code got removed in Bug 1628052 so no longer an issue.

Status: NEW → RESOLVED
Closed: 4 years ago
Component: DOM: Content Processes → Tours
Product: Core → Firefox
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.