1628052 - Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P2)

Description

[Andrew McCreight [:mccr8]]

I've sprinkled uses of this pref around in various places to avoid intermittent Fission leaks. If bug 1612364 really fixes bug 1576498, then we should remove all of the uses of that pref that I added to fix leaks.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1628052 - Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks.

Comment 2

[Andrew McCreight [:mccr8]]

I also added these to fix hangs, but I'm hoping that's uh not too much of an issue now? For some reason? I think one of the worker shutdown hangs got fixed.

Comment 3

[Chris Peterson [:cpeterson]]

P3
Fission M6

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/894ebe92bdae
Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks. r=kmag

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/894ebe92bdae

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82550851a0d1
Backed out changeset 894ebe92bdae for causing failure increase in bug 1358898 CLOSED TREE

Comment 7

[Andreea Pavel [:apavel]]

Backed out due to increasing failures on fission in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1358898#c308

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/82550851a0d1

Comment 9

[Andrew McCreight [:mccr8]]

Some of these prefs were added to paper over leaks and some were added to paper over hangs. The next step here would be to look at the bugs associated with each place I changed the pref, figure out whether it was for a leak or for a hang, then come up with a new version of the patch that only reverts the changes for the leaks.

Ideally, of course, we'd figure out the shutdown hangs and revert them all, but that's a lot more work, and I don't think it is on anybody's task list.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8cf96fbbc64
Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks. r=kmag

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e8cf96fbbc64