1595255 - TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js - Port bug 1578887

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js | - Rotated width of 480 - 320 == 480
TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js | - A promise chain failed to handle a rejection: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref] - stack: rotateViewport/<@resource://devtools/client/responsive/actions/viewports.js:112:26

This comes from bug 1578887:
https://hg.mozilla.org/mozilla-central/rev/682483b64a30714b3adf47feb2586bdacdc1800b

Looks like we need to add pref devtools.responsive.browserUI.enabled

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1595255-devtools-prefs.patch

That's a copy from firefox.js.

-pref("devtools.webide.enabled", false);
-pref("devtools.connectpage.enabled", false);

no longer exist, so I removed them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f66f154ecd6b
Port recent devtool pref changes. rs=bustage-fix DONTBUILD

Comment 3

[Richard Marti (:Paenglab)]

You added some defined(MOZ_DEV_EDITION) which we don't use.

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks for checking. Those defines are always in lines like #if defined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION). Since we don't use it, there's no problem. I suggest to leave them to be closer to the FF version for further ports. Do you disagree?

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9107652 [details] [diff] [review]
1595255-devtools-prefs.patch

Review of attachment 9107652 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, I'd take out the ifdef MOZ_DEV_EDITIONs