Closed Bug 1595255 Opened 5 months ago Closed 5 months ago

TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js - Port bug 1578887

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js | - Rotated width of 480 - 320 == 480
TEST-UNEXPECTED-FAIL | devtools/client/responsive/test/unit/test_rotate_viewport.js | - A promise chain failed to handle a rejection: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref] - stack: rotateViewport/<@resource://devtools/client/responsive/actions/viewports.js:112:26

This comes from bug 1578887:
https://hg.mozilla.org/mozilla-central/rev/682483b64a30714b3adf47feb2586bdacdc1800b

Looks like we need to add pref devtools.responsive.browserUI.enabled

That's a copy from firefox.js.

-pref("devtools.webide.enabled", false);
-pref("devtools.connectpage.enabled", false);

no longer exist, so I removed them.

Assignee: nobody → jorgk
Attachment #9107652 - Flags: review?(mkmelin+mozilla)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f66f154ecd6b
Port recent devtool pref changes. rs=bustage-fix DONTBUILD

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0

You added some defined(MOZ_DEV_EDITION) which we don't use.

Thanks for checking. Those defines are always in lines like #if defined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION). Since we don't use it, there's no problem. I suggest to leave them to be closer to the FF version for further ports. Do you disagree?

Comment on attachment 9107652 [details] [diff] [review]
1595255-devtools-prefs.patch

Review of attachment 9107652 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, I'd take out the ifdef MOZ_DEV_EDITIONs
Attachment #9107652 - Flags: review?(mkmelin+mozilla) → review+
You need to log in before you can comment on or make changes to this bug.