1595471 - Search/Suggest Parameters for the modern config should be within a code section

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

In attempting more uploads to the staging server for remote settings, I noticed that our current searchUrlGetParams/suggestUrlGetParams (and post) sections are currently not within a code sub-section.

Additionally, the schema is getting some labels wrong, and so we never display an option on the staging UI for setting the get parameters.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1595471 - Fix issues with search/suggest url parameters being not specified correctly in the schema, and missing a 'params' wrapper in the config. r?mikedeboer

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1595471 - Fix the modern search engine schema regexp to allow all the various locale codes that we currently use. r?mikedeboer

Depends on D52537

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1595471 - Correct ja-JP-macos references in engines.json for the modern configuration. r?mikedeboer

Depends on D52538

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/834ce8215277
Fix issues with search/suggest url parameters being not specified correctly in the schema, and missing a 'params' wrapper in the config. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/1b6f8be366c7
Fix the modern search engine schema regexp to allow all the various locale codes that we currently use. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/fe249d311026
Correct ja-JP-macos references in engines.json for the modern configuration. r=mikedeboer

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/834ce8215277
https://hg.mozilla.org/mozilla-central/rev/1b6f8be366c7
https://hg.mozilla.org/mozilla-central/rev/fe249d311026