1595536 - "Firefox" not entirely visible on about:firefox

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Sorina Florean [:sflorean]]

Attachment: Screenshot_20191111-135418.jpg

Environment:
Build esr68 (Release, Beta, Nightly);
Device:

• Huawei MediaPad M2 (Android 5.1.1)
• Nexus 5 (Android 6.0.1)
• Nokia 6 (Android 7.1.1)
• Samsung Galaxy S8 (Android 9)
• OnePlus 5T (Android 9.0)
• Xiaomi Mi Pad 2 (Android 5.1 - x86 architecture);

Steps to reproduce:

1. Open Fennec and go to about:firefox.
2. Pay attention to "Firefox".

Expected result: "Firefox" is displayed without visual issues.

Actual result: the text is not entirely visible.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1595536 - Allow the Firefox workmark to be as wide as the parent; r?AndreiLazar

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Visible Firefox wordmark.png

Bug 1589422 replaced the wordmark containing only "Firefox" with a new one containing "Firefox Browser".
So we needed to account for a bigger width of the div displaying it.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9110852 [details]
Bug 1595536 - Allow the Firefox workmark to be as wide as the parent; r?AndreiLazar

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Important UX issue for a high priority UI element.
• User impact if declined: Important imagery is highly cropped in about:firefox
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change.
• String or UUID changes made by this patch:

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9110852 [details]
Bug 1595536 - Allow the Firefox workmark to be as wide as the parent; r?AndreiLazar

Minor tweak to layout, OK for uplift for Fennec 68.3

Comment 6

[Sören Hentzschel]

The screenshot in comment #3 shows that it's still truncated at the bottom. Please look at the "e", "s" or "o" character. It's not much but it's definitively noticeable…

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Attachment: Perfectly rendered wordmark .png

Thanks Sören!
Indeed the image seemed to have it's bottom slightly cropped.
I guess the best compromise here would be to just increase it's height, with just 1 pixel, which seems to result in it being perfectly rendered.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/d7a05a5f82fe

Comment 9

[Sorina Florean [:sflorean]]

Verified as fixed on ESR builds 68.3b6, 68.3a1.
Devices: Google Pixel (Android Q), Samsung Galaxy Tab S3 (Android 8.0).

Comment 10

[Sorina Florean [:sflorean]]

Confirming the fix as well on 68.3.0 RC.