1595677 - The profiler popup should follow dark/light changes even in the default theme

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Bug 1579982 made the popup theme respect browser theme when either dark or light theme are explicitly set. However if the default theme is set, Firefox respects OS setting and switches accordingly, but the profiler popup stays light themed. This can be observed on macOS by switching the OS theme to dark, observing the browser theme change (even at the default theme setting) and the profiler popup remaining light.

Comment 1

[Michael Hoffmann]

Ah, sorry, I missed that in the previous bug. I'll take this one and fix it :)

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Panos, do you know of some code example where this has been implemented? Otherwise we'll look after it but it's easier if you know some from the top of your head :)

Comment 3

[Michael Hoffmann]

It is in toolkit/modules/LightweightThemeConsumer.jsm, if darkMode() returns true, it flips the whole theme to dark (if available). So it is the whole theme that adapts to the system settings.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:julienw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Michael Hoffmann]

FYI, I'm waiting for bug 1598863 to get resolved. When I can push to try I'll be able to try out my changes on non-Linux systems.

Comment 6

[Michael Hoffmann]

Attachment: Bug 1595677 - Support dark mode profiler popup in default theme for Win and Mac

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57bdc84b399
Support dark mode profiler popup in default theme for Win and Mac r=canaltinova

Comment 8

[Michael Hoffmann]

The patch that has been pushed fixes this problem on Mac and Windows.

It does unfortunately not work on Linux, since there we don't use a system-wide dark theme setting. Instead we rely on the GTK theme colors when the default theme is chosen. Since the popup only has two modes, light and dark, we are unable to respond to these system-wide themes appropriately. This problem actually appears on Windows too, since there one can also specify system themes. If, instead of choosing the preset dark mode setting, one chooses a Windows theme, say, the high contrast theme, then the popup will continue to show its light appearance. Since I've never used a Mac, I don't know if this problem manifests itself there.

In any case, this change at least makes things a little better. The proper solution the the problems above would be to support full Firefox theming in the profiler popup. But since that is quite involved, it could perhaps be deferred until the new design is implemented.

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e57bdc84b399