Closed Bug 1595706 Opened 5 years ago Closed 9 months ago

Add support for "acceptLanguage" to Emulation.setUserAgentOverride

Categories

(Remote Protocol :: CDP, task, P5)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned)

References

()

Details

(Whiteboard: [lang=js])

With bug 1595697 we will get the basic implementation of Emulation.setUserAgentOverride, which only handles the user agent.

This bug covers the addition of the acceptLanguage option. Similar to the userAgent the preferred language can be set via a preference. In this case it will be intl.accept_languages. It's a string preference and accepts a list of languages separated by comma. Given that the input is a string it should directly be set.

The files to make the changes can be found at:
https://searchfox.org/mozilla-central/source/remote/domains/parent/Emulation.jsm
https://searchfox.org/mozilla-central/source/remote/test/browser/emulation/browser_setUserAgentOverride.js

To get started please read:
https://firefox-source-docs.mozilla.org/remote/index.html

As it turned out there are two implementations. The one from the Network domain simply redirects to the Emulation domain. Updating the bug and dependencies accordingly.

Blocks: 1596097
No longer blocks: 1549464
Summary: Add support for "acceptLanguage" to Network.setUserAgentOverride → Add support for "acceptLanguage" to Emulation.setUserAgentOverride
Mentor: hskupin
Whiteboard: [lang=js]
Component: Network → Emulation
Blocks: 1596136
Component: CDP: Emulation → CDP
Severity: normal → S3
Mentor: hskupin
Priority: P3 → P5

We are not going to implement this emulation feature for CDP, but for WebDriver BiDi eventually.

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.