1595697 - Implement Emulation.setUserAgentOverride

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Running the Puppeteer example for fullpage screenshots the device is set via page.emulate() to iPhone6. This causes the following command send to Firefox:

  puppeteer:protocol SEND ► {"sessionId":1,"method":"Network.setUserAgentOverride","params":{"userAgent":"Mozilla/5.0 (iPhone; CPU iPhone OS 11_0 like Mac OS X) AppleWebKit/604.1.38 (KHTML, like Gecko) Version/11.0 Mobile/15A372 Safari/604.1"},"id":19} +1ms

What we need here is an override for the user agent so that other browsers, and platforms can be emulated. To get this done the general.useragent.override preference could be used.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d88b2ac414392af9b81cc7a24662b78cb2da842

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1595697 - [remote] Implement basic support for Emulation.setUserAgentOverride.

This patch implements setting the user agent only. Support for
accepted language, and platform will be done in a follow-up bug.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

As it turned out there are two implementations. The one from the Network domain simply redirects to the Emulation domain. Updating the bug and dependencies accordingly.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=912eacdb4bccfb02457b255af0a3f05d3dc1fc99

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73c00aa07450
[remote] Implement basic support for Emulation.setUserAgentOverride. r=remote-protocol-reviewers,maja_zf

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/73c00aa07450