Closed Bug 1595812 Opened 1 year ago Closed 1 year ago

Fix broken include guard in IntentionalCrash.h

Categories

(Core :: XPCOM, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

This file has an include guard, but it comes after it includes other files. This change also makes clang-format not indent some other ifdefs in the file, presumably because valid include guards don't increase the indentation.

The include guard needs to happen before any non-trivial tokens.

I guess this change made clang-format decide the other ifdefs aren't
actually nested, so it dropped the indents.

It looks like this dates to the creation of this file in bug 602891.

See Also: → 1595828
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c96a028aaafa
Fix include guard in IntentionalCrash.h. r=froydnj
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.