1596040 - Link relList support returns false for manifest

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[me]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.87 Safari/537.36

Steps to reproduce:

We're trying to detect the "A2HS" (Add to Home Screen) support.

For our PWA is crucial to promote the installation when the feature is supported (either manual or app triggered).

As far as we know, the only reliable way is to check the result of the following:

document.createElement('link').relList.supports('manifest');

Actual results:

It returns false.

Expected results:

Expected true.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Moving this to GeckoView for triage. It is unlikely we will fix this for Fennec, but if this is also an issue in FIrefox Preview (Fenix) then we can get it on the roadmap there.

"me" - are you able to check this bug on Firefox Preview?

Comment 2

[Emily Toop (:fluffyemily)]

James says it likely needs DOM work. :marcosc, can you take a look please?

Comment 3

[Marcos Caceres [:marcosc]]

Sorry for the delay. Will take it.

Comment 4

[Marcos Caceres [:marcosc]]

Attachment: Teach HTMLLinkElement's relList about 'manifest'

Fenix wants to ship Web Manifest support, while other Firefox products (e.g., Desktop) don't support it.

With the pref enabled, developers can check, via link.relList.supports(), if manifest processing is supported by a particular product.

Comment 5

[Marcos Caceres [:marcosc]]

Try is happy:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5f5ae44fab7ee86fd904d446cdd872e49fdbab6

But needs a rebase... and that means doing it on a different computer. Oh Phabricator... le sigh.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37e5dfd85236
Teach HTMLLinkElement's relList about 'manifest' r=bzbarsky

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/37e5dfd85236

Comment 8

[me]

Thanks!!! 🦊😻

Comment 9

[Marcos Caceres [:marcosc]]

Just a note for anyone landing here: link.relList.supports("manifest") will only return true on a product-by-product basis (conditional on the product actually doing something useful with web manifest)... so initially, only Firefox Preview will return "true" (bug 1603673) - but all other Firefoxes will return false.