Closed Bug 1596045 Opened 5 years ago Closed 5 years ago

Intermittent netwerk/test/unit/test_esni_dns_fetch.js | onLookupByTypeComplete - [onLookupByTypeComplete : 77] false == true

Categories

(Core :: Networking, defect, P2)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: valentin)

References

Details

(Keywords: intermittent-failure, Whiteboard: [necko-triaged][trr])

Attachments

(1 file)

Bug 1596045 - Modernize test_esni_dns_fetch.js and make sure we're not clearing the cache when setting the URI pref r=dragana
47 bytes, text/x-phabricator-request
Details | Review

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=275970449&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/SbI5i6aqSYikUJHA31d4Hw/runs/0/artifacts/public/logs/live_backing.log

[task 2019-11-13T08:38:41.521Z] 08:38:41 INFO - TEST-START | netwerk/test/unit/test_esni_dns_fetch.js
[task 2019-11-13T08:38:43.937Z] 08:38:43 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_esni_dns_fetch.js | xpcshell return code: 0
[task 2019-11-13T08:38:43.938Z] 08:38:43 INFO - TEST-INFO took 2415ms
[task 2019-11-13T08:38:43.939Z] 08:38:43 INFO - >>>>>>>
[task 2019-11-13T08:38:43.940Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.940Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.941Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.942Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.942Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.943Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.944Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.944Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.945Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.945Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.946Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.947Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.947Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2632
[task 2019-11-13T08:38:43.948Z] 08:38:43 INFO - PID 19283 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2019-11-13T08:38:43.948Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: 'result.isErr()', file /builds/worker/workspace/build/src/startupcache/StartupCache.cpp, line 173
[task 2019-11-13T08:38:43.949Z] 08:38:43 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2019-11-13T08:38:43.950Z] 08:38:43 INFO - TEST-PASS | netwerk/test/unit/test_esni_dns_fetch.js | run_test - [run_test : 20] "46854" != null
[task 2019-11-13T08:38:43.950Z] 08:38:43 INFO - TEST-PASS | netwerk/test/unit/test_esni_dns_fetch.js | run_test - [run_test : 21] "46854" != ""
[task 2019-11-13T08:38:43.951Z] 08:38:43 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-11-13T08:38:43.951Z] 08:38:43 INFO - PID 19283 | starting test 0
[task 2019-11-13T08:38:43.952Z] 08:38:43 INFO - (xpcshell/head.js) | test pending (3)
[task 2019-11-13T08:38:43.952Z] 08:38:43 INFO - (xpcshell/head.js) | test MAIN run_test finished (3)
[task 2019-11-13T08:38:43.952Z] 08:38:43 INFO - running event loop
[task 2019-11-13T08:38:43.953Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/workspace/build/src/dom/media/CubebUtils.cpp, line 381
[task 2019-11-13T08:38:43.954Z] 08:38:43 INFO - "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2019-11-13T08:38:43.955Z] 08:38:43 INFO - PID 19283 | [19283, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002: file /builds/worker/workspace/build/src/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 661
[task 2019-11-13T08:38:43.956Z] 08:38:43 INFO - TEST-PASS | netwerk/test/unit/test_esni_dns_fetch.js | onLookupByTypeComplete - [onLookupByTypeComplete : 77] true == true
[task 2019-11-13T08:38:43.957Z] 08:38:43 INFO - TEST-PASS | netwerk/test/unit/test_esni_dns_fetch.js | onLookupByTypeComplete - [onLookupByTypeComplete : 79] "bXkgdm9pY2UgaXMgbXkgcGFzc3dvcmQ=" == "bXkgdm9pY2UgaXMgbXkgcGFzc3dvcmQ="
[task 2019-11-13T08:38:43.957Z] 08:38:43 INFO - (xpcshell/head.js) | test finished (2)
[task 2019-11-13T08:38:43.958Z] 08:38:43 INFO - PID 19283 | starting test 1
[task 2019-11-13T08:38:43.964Z] 08:38:43 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-11-13T08:38:43.965Z] 08:38:43 INFO - TEST-PASS | netwerk/test/unit/test_esni_dns_fetch.js | onLookupComplete - [onLookupComplete : 91] true == true
[task 2019-11-13T08:38:43.966Z] 08:38:43 INFO - TEST-PASS | netwerk/test/unit/test_esni_dns_fetch.js | onLookupComplete - [onLookupComplete : 93] "127.0.0.1" == "127.0.0.1"
[task 2019-11-13T08:38:43.966Z] 08:38:43 INFO - (xpcshell/head.js) | test finished (2)
[task 2019-11-13T08:38:43.967Z] 08:38:43 INFO - PID 19283 | starting test 2
[task 2019-11-13T08:38:43.968Z] 08:38:43 INFO - (xpcshell/head.js) | test pending (2)
[task 2019-11-13T08:38:43.968Z] 08:38:43 WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_esni_dns_fetch.js | onLookupByTypeComplete - [onLookupByTypeComplete : 77] false == true
[task 2019-11-13T08:38:43.969Z] 08:38:43 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/netwerk/test/unit/test_esni_dns_fetch.js:onLookupByTypeComplete:77
[task 2019-11-13T08:38:43.969Z] 08:38:43 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:246
[task 2019-11-13T08:38:43.970Z] 08:38:43 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:573

This seems to fail when checking testEsniPushPart2.
The reason it's intermittent is that we clear the DNS cache when we set the TRR URI pref - that is scheduled whenever the JS pauses, so if that happens we get an intermittent failure such as this.

Assignee: nobody → valentin.gosu
Priority: P5 → P2
Whiteboard: [necko-triaged][trr]

When using add_task to schedule the tests, testEsniPushPart2 would always fail.
That's because Bug 1587875 now clears the DNS cache when the network.trr.uri
pref is changed. This is likely intermittent because of task scheduling.
This patch modernizes the test to use add_task and promises, and sets the
network.trr.clear-cache-on-pref-change;true pref so the test performs its
checks properly.

Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/360c8b9f1566 Modernize test_esni_dns_fetch.js and make sure we're not clearing the cache when setting the URI pref r=dragana

https://hg.mozilla.org/mozilla-central/rev/360c8b9f1566

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: