Disable MediaCapabilities performance benchmarks in Release (71)
Categories
(Core :: Audio/Video: Playback, task, P1)
Tracking
()
People
(Reporter: achronop, Assigned: achronop)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
pascalc
:
approval-mozilla-release-
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
pascalc
:
approval-mozilla-release-
|
Details | Review |
Performance benchmarks are implemented behind the pref media.mediacapabilities.from-database.
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya
Beta/Release Uplift Approval Request
- User impact if declined: Crashes, this depends on RKV, which crashes in the release.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: Video playback on youtube or any other page.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Not risky, it disables the new way of checking media capabilities in favor of the old one. Not RKV access on the old functionality.
- String changes made/needed:
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 9108655 [details]
Bug 1596064 - Remove any access on the database when pref is off. r?jya
Beta/Release Uplift Approval Request
- User impact if declined: Crashes, this depends on RKV, which crashes in the release.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: Video playback on youtube or any other page.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Not risky, it disables the new way of checking media capabilities in favor of the old one. Not RKV access on the old functionality.
- String changes made/needed:
Updated•6 years ago
|
Updated•6 years ago
|
Comment 7•6 years ago
|
||
So far, we don't have another dot release for 70 planned. But, you could still request uplift to beta 71.
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/530bb2d5095a
https://hg.mozilla.org/mozilla-central/rev/f8d156649aaa
Assignee | ||
Comment 9•6 years ago
|
||
Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya
Beta/Release Uplift Approval Request
- User impact if declined: Crashes, this depends on RKV, which crashes in the release.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Not risky, it disables the new way of checking media capabilities in favor of the old one. Not RKV access on the old functionality.
- String changes made/needed:
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya
Crash fix, uplift approved for 71 beta 11, thanks.
Updated•6 years ago
|
Comment 11•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya
Removing the approval request for 70 as we are shipping 71 and this was uplifed in beta.
Updated•6 years ago
|
Description
•