Closed Bug 1596064 Opened 1 year ago Closed 1 year ago

Disable MediaCapabilities performance benchmarks in Release (71)

Categories

(Core :: Audio/Video: Playback, task, P1)

Product:
Core
Component:
Audio/Video: Playback
Version:
70 Branch
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox70 --- wontfix
firefox71 + fixed
firefox72 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

Details

Attachments

(2 files)

Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
pascalc
: approval-mozilla-release-
Details | Review
Bug 1596064 - Remove any access on the database when pref is off. r?jya
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
pascalc
: approval-mozilla-release-
Details | Review

Performance benchmarks are implemented behind the pref media.mediacapabilities.from-database.

Status: NEW → ASSIGNED
Type: defect → task

Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes, this depends on RKV, which crashes in the release.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Video playback on youtube or any other page.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky, it disables the new way of checking media capabilities in favor of the old one. Not RKV access on the old functionality.
  • String changes made/needed:
Attachment #9108395 - Flags: approval-mozilla-release?
No longer blocks: 1596012

Comment on attachment 9108655 [details]
Bug 1596064 - Remove any access on the database when pref is off. r?jya

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes, this depends on RKV, which crashes in the release.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Video playback on youtube or any other page.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky, it disables the new way of checking media capabilities in favor of the old one. Not RKV access on the old functionality.
  • String changes made/needed:
Attachment #9108655 - Flags: approval-mozilla-release?
Attachment #9108395 - Attachment description: Bug 1596064 - Disable MediaCapabilities performance benchmarks in Release. r?jya → Bug 1596064 - Disable MediaCapabilities performance benchmarks. r?jya
Attachment #9108395 - Attachment description: Bug 1596064 - Disable MediaCapabilities performance benchmarks. r?jya → Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/530bb2d5095a
Only enable MediaCapabilities performance benchmarks on Nightly. r=jya
https://hg.mozilla.org/integration/autoland/rev/f8d156649aaa
Remove any access on the database when pref is off. r=jya

So far, we don't have another dot release for 70 planned. But, you could still request uplift to beta 71.

Flags: needinfo?(achronop)

https://hg.mozilla.org/mozilla-central/rev/530bb2d5095a
https://hg.mozilla.org/mozilla-central/rev/f8d156649aaa

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes, this depends on RKV, which crashes in the release.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky, it disables the new way of checking media capabilities in favor of the old one. Not RKV access on the old functionality.
  • String changes made/needed:
Flags: needinfo?(achronop)
Attachment #9108395 - Flags: approval-mozilla-beta?
Attachment #9108655 - Flags: approval-mozilla-beta?

Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya

Crash fix, uplift approved for 71 beta 11, thanks.

Attachment #9108395 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9108655 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox70: --- → wontfix
Summary: Disable MediaCapabilities performance benchmarks in Release (70) → Disable MediaCapabilities performance benchmarks in Release (71)

Comment on attachment 9108395 [details]
Bug 1596064 - Only enable MediaCapabilities performance benchmarks on Nightly. r?jya

Removing the approval request for 70 as we are shipping 71 and this was uplifed in beta.

Attachment #9108395 - Flags: approval-mozilla-release? → approval-mozilla-release-
Attachment #9108655 - Flags: approval-mozilla-release? → approval-mozilla-release-
No longer blocks: ship-rkv
You need to log in before you can comment on or make changes to this bug.