1597898 - Use RKV safe mode for kvstore

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, enhancement, P2)

Description

[Victor Porof [:vporof][:vp]]

Since kvstore is an RKV wrapper, and RKV is not supposed to be enabled in release when using an LMDB backend, about:support and MediaCapabilities performance benchmarks should use kvstore with safe mode enabled instead.

This bug is a merge of bug 1596012 and bug 1596051, since a single fix applies to both.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1597898 - Part 1: Update RKV dependency to safe-mode, r=nanj

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1597898 - Part 2: Vendor newly added rust dependencies, r=nanj

Depends on D54279

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1597898 - Part 3: Update kvstore to use RKV in safe mode, r=nanj

Depends on D54281

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:vporof, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Victor Porof [:vporof][:vp]]

Landing soon.
Update: this was deprioritized after the reorg, shelved.

Comment 8

[Victor Porof [:vporof][:vp]]

I am now picking back up the work here.

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

Any update on this? :)

Comment 10

[Victor Porof [:vporof][:vp]]

On it and hope to land asap before the soft freeze. Thanks for the ping!

Comment 11

[Victor Porof [:vporof][:vp]]

Automatic migration between backends now landed in RKV and pushed to crates.io.
Just rebased the patches and doing one last try run before landing.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac992b048e32
Part 1: Update RKV dependency to safe-mode, r=nanj
https://hg.mozilla.org/integration/autoland/rev/3cfb899ae94c
Part 2: Vendor newly added rust dependencies, r=nanj
https://hg.mozilla.org/integration/autoland/rev/5159ffa5705c
Part 3: Update kvstore to use RKV in safe mode, r=nanj

Comment 13

[Andreea Pavel [:apavel]]

Backed out for breaking raptor on win 7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=5159ffa5705c0393988784bb76f67e32b9aa3352&selectedTaskRun=Zxy2J3O1QC2Q-zH1pie9zA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310976486&repo=autoland&lineNumber=995

Backout: https://hg.mozilla.org/integration/autoland/rev/6796ad94734afad26e9d8873a4c2e9dbf5e0f31a

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56c0d0013fda
Part 1: Update RKV dependency to safe-mode, r=nanj
https://hg.mozilla.org/integration/autoland/rev/ef1582f630a5
Part 2: Vendor newly added rust dependencies, r=nanj
https://hg.mozilla.org/integration/autoland/rev/4e651edaacde
Part 3: Update kvstore to use RKV in safe mode, r=nanj

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/56c0d0013fda
https://hg.mozilla.org/mozilla-central/rev/ef1582f630a5
https://hg.mozilla.org/mozilla-central/rev/4e651edaacde