1596065 - Disable the access to RKV for about:support

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alex Chronopoulos [:achronop]]

This code will be wrapped around a pref and will pref off.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1596065 - Hide database enumeration option in about:support if the pref is off. r?chunmin

Wrap around the pref media.mediacapabilities.from-database the option to enumerate MediaCapabilities database in about:support page. When the pref is off the button disappears and the enumeration method returns early.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/945c10e9ab6b
Hide database enumeration option in about:support if the pref is off. r=chunmin

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/945c10e9ab6b

Comment 4

[Victor Porof [:vporof][:vp]]

Shouldn't this also land in 71?

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Victor Porof [:vporof][:vp] from comment #4)

Shouldn't this also land in 71?

Yes, can you or achronop make the uplift request today so as that it gets into beta tomorrow please? Thanks

Comment 6

[Alex Chronopoulos [:achronop]]

Comment on attachment 9108687 [details]
Bug 1596065 - Hide database enumeration option in about:support if the pref is off. r?chunmin

Beta/Release Uplift Approval Request

• User impact if declined: Crashes, it accesses the RKV database, which is crashing.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a change in the JS level and it just removes the use of the offending methods.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9108687 [details]
Bug 1596065 - Hide database enumeration option in about:support if the pref is off. r?chunmin

Planned Uplift approved for 71 beta 12, thanks.

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/75ad02f5fe90