Closed Bug 1596101 Opened 3 months ago Closed 3 months ago

Forward Network.setUserAgentOverride to Emulation.setUserAgentOverride

Categories

(Remote Protocol :: Network, task, P1)

Tracking

(firefox72 fixed)

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [puppeteer-alpha])

Attachments

(1 file)

Once bug 1595697 has been fixed we will have to put a redirect into place which simply forwards the call to Emulation.setUserAgentOverride.

This redirect is required by Puppeteer:
https://github.com/GoogleChrome/puppeteer/blob/c2651c2b5cc888ebd0ca6be87063d9f98b9eb59c/lib/NetworkManager.js#L112

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1

The method under the Network domain is a redirect to
Emulation only. It might be deprecated, but that's unclear
in the current documentation.

Depends on D52831

Summary: Implement redirect to "Emulation.setUserAgentOverride" → Forward Network.setUserAgentOverride to Emulation.setUserAgentOverride
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/06d19681d042
[remote] Forward Network.setUserAgentOverride to Emulation.setUserAgentOverride. r=remote-protocol-reviewers,maja_zf
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.