1596166 - UA input disappears from toolbar when window width is small

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Micah [:mtigley] (she/her)]

Steps to Reproduce

1. Make sure devtools.responsive.browserUI.enabled and devtools.responsive.showUserAgentInput prefs are true.
2. Open RDM.
3. Resize window width to less than half the screen.

ER
User-agent input should go to the next line of the toolbar to accommodate for the lack of space.

AR
User-agent input disappears.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Screen Shot 2019-11-13 at 1.25.30 PM.png

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1596166 - Remove "height: 30px" on RDM toolbar

The UA input field gets caught off when the browser viewport is too small. This is because the RDM toolbar has an explicit height of 30px set on it, so it can't accomodate the second row created for the UA input.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b7a473e92d3
Remove "height: 30px" on RDM toolbar r=bgrins

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2b7a473e92d3

Comment 5

[Ciprian Georgiu, Desktop QA]

I was able to reproduce the bug using the STR from comment 0, on an affected Nightly build (2019-11-13).

This bus is verified fixed on Beta 73.0b6 across platforms: Win 10 x64, macOS 10.13 and Ubuntu 16.04 x86.