1604729 - The device modal of the browser-embedded RDM should resize vertically too

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Patrick Brosset <:pbro>]

Steps:

• Make sure you have the new RDM turned on devtools.responsive.browserUI.enabled
• Open RDM on any page
• Open the device modal window
• Resize your browser window until the bottom of the device modal becomes hidden

Expected: like today with the old RDM, the device modal should resize both horizontally and vertically to adapt to the browser window size, so it always remains visible.

Actual: the bottom of the modal becomes hidden and you can't access certain elements.

Comment 1

[Micah [:mtigley] (she/her)]

As per comment in: https://bugzilla.mozilla.org/show_bug.cgi?id=1604726#c3

We can fix this by adding height: 100% when the device modal is opened.

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1604729 - Make device modal height take up 100% of the browser stack.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178c4ce41ba6
Make device modal height take up 100% of the browser stack. r=bradwerth

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/178c4ce41ba6

Comment 5

[Cristian Fogel [:cfogel]]

Confirmed issue with 73.0a1 (2019-12-15) on Windows 10 & 73.0 on Ubuntu 19.04.
Fix verified with 75.0a1 (2020-02-18) & 74.0b4 on Windows 10; 74.0b4 on macOS 10.15.3, Ubuntu 19.04.