Closed Bug 1604729 Opened 5 years ago Closed 4 years ago

The device modal of the browser-embedded RDM should resize vertically too

Categories

(DevTools :: Responsive Design Mode, defect, P1)

defect

Tracking

(firefox74 verified)

VERIFIED FIXED
Firefox 74
Tracking Status
firefox74 --- verified

People

(Reporter: pbro, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: fission-rdm-mvp)

Attachments

(1 file)

Steps:

  • Make sure you have the new RDM turned on devtools.responsive.browserUI.enabled
  • Open RDM on any page
  • Open the device modal window
  • Resize your browser window until the bottom of the device modal becomes hidden

Expected: like today with the old RDM, the device modal should resize both horizontally and vertically to adapt to the browser window size, so it always remains visible.

Actual: the bottom of the modal becomes hidden and you can't access certain elements.

Priority: -- → P3
Whiteboard: fission-rdm-reserve
Regressions: 1596166

As per comment in: https://bugzilla.mozilla.org/show_bug.cgi?id=1604726#c3

We can fix this by adding height: 100% when the device modal is opened.

Assignee: nobody → mtigley
Priority: P3 → P1
Status: NEW → ASSIGNED
Whiteboard: fission-rdm-reserve → fission-rdm-mvp
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/178c4ce41ba6
Make device modal height take up 100% of the browser stack. r=bradwerth
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Flags: qe-verify+

Confirmed issue with 73.0a1 (2019-12-15) on Windows 10 & 73.0 on Ubuntu 19.04.
Fix verified with 75.0a1 (2020-02-18) & 74.0b4 on Windows 10; 74.0b4 on macOS 10.15.3, Ubuntu 19.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: