Closed Bug 1596296 Opened 3 months ago Closed 3 months ago

Stop supporting XUL [dir="reverse"] attribute value

Categories

(Toolkit :: XUL Widgets, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The XUL dir attribute can be set to reverse to set -moz-box-direction: reverse;.

This attribute seems unused:

Furthermore, this conflicts and causes confusion with the HTML dir attribute which takes ltr/auto/rtl as values.

Good idea, I was wondering about this while doing breakdown for stuff like Bug 1593023.

See Also: → 1593023
Summary: Stop supporting the XUL `dir` attribute → Stop supporting XUL [dir="reverse"] attribute value
Depends on: 1596385
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f03a850e3f53
Stop supporting XUL [dir="reverse"] attribute value. r=dholbert

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=276421433&resultStatus=testfailed%2Cbusted%2Cexception&revision=f03a850e3f537a33d65889797230222b305f7f7f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=276421433&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/53c096b278f5888d8b7590786628b0634a80ed2f

[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - TEST-PASS | toolkit/content/tests/widgets/test_popupanchor.xhtml | arrow should not have moved: 182 should be equal(-ish) to 182
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - Buffered messages finished
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_popupanchor.xhtml | arrow should not have moved up or down: 47 should be equal(-ish) to 57
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:277:18
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - is_close@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_popupanchor.xhtml:23:5
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - tests</</<@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_popupanchor.xhtml:302:19
[task 2019-11-15T13:27:03.024Z] 13:27:03 INFO - sub-test middle.veryTallPanel-start_after starting
[task 2019-11-15T13:27:03.025Z] 13:27:03 INFO - TEST-PASS | toolkit/content/tests/widgets/test_popupanchor.xhtml | height is what we requested.

Flags: needinfo?(ntim.bugs)

Tim, I think you missed two instances of container.dir being set in those two Custom Element implementations. The patch on autoland only seemed to change two instances but I see four in each file:

places-menupopup.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=places-menupopup.js
panel.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=panel.js

(In reply to Brian Grinstead [:bgrins] from comment #5)

Tim, I think you missed two instances of container.dir being set in those two Custom Element implementations. The patch on autoland only seemed to change two instances but I see four in each file:

places-menupopup.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=places-menupopup.js
panel.js - https://searchfox.org/mozilla-central/search?q=container.dir&path=panel.js

Good catch, thanks!

Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4c41a3b36c68
Stop supporting XUL [dir="reverse"] attribute value. r=dholbert
Blocks: 1592369
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → ntim.bugs
You need to log in before you can comment on or make changes to this bug.