1596345 - Update browser_toolbox_tools_per_toolbox_registration.js to avoid failures when default tool list is modified

Status: NEW

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

In Bug 1594885, we added a new What's New panel, which made the available space in the toolbar smaller.

This led to failures on asan for browser_toolbox_tools_per_toolbox_registration.js where the test tool's tab could not be found.

This was fixed by making the test tab name shorter, because from the investigation it seems the issue is simply that under some conditions the test tab might overflow and move to the overflow menu (even though it was not clear why this only failed on ASAN in this test).

But the test should make sure either to consider the case where tabs overflow, or reduce the list of visible tabs to the minimum so that this doesn't happen.

Comment 1

[Julian Descottes [:jdescottes]]

Was discussing this issue with :nchevobbe who suggested checking if the screen size was different with asan. I think it would be a great way to investigate things here: do a try run both in asan and non-asan, that logs the screen size, browser size, browser position, toolbox dimensions.

If we see differences for any of those between asan and non-asan, it will indicate that we probably have something else running in the same chunk that has a sideeffect on the browser_toolbox_tools_per_toolbox_registration.js test. If not then it's a bit more concerning, as I can't understand why the behavior would be different on asan at all.