Closed Bug 1596572 Opened 1 year ago Closed 11 months ago

make CompareStringInfinityOrNaN work with clang 5.x and C++17

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

No description provided.

clang 5.x (which is now our minimum supported clang version as of bug
1579189) doesn't quite work with inline variables and C++17.
Fortunately, we can make some straightforward changes to make the code
for CompareStringInfinityOrNan work in such situations.

Priority: -- → P1
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c468a5b5996
make CompareStringInfinityOrNaN work with clang 5.x and C++17; r=jandem
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.