1596588 - WebPushController.onPushEvent should only need the scope

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Jonathan Almeida [:jonalmeida]]

When delivering a message to GeckoView, the scope is the only attribute needed for doing so in the WebPushScription. We should change the API to reflect that since passing the full subscription back for every message is harder to reconstruct and unsafe as well.

From:
onPushEvent(WebPushSubscription subscription)
onPushEvent(WebPushSubscription subscription, byte[] data)

To:
onPushEvent(String scope)
onPushEvent(String scope, byte[] data)

Comment 1

[Jonathan Almeida [:jonalmeida]]

I might take a stab at fixing this if I can get my build environment setup before someone else sees this.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1596588 - Update WebPushController.onPushEvent to take only the scope. r=snorp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21632bd4c4ca
Update WebPushController.onPushEvent to take only the scope. r=snorp

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 21632bd4c4ca (bug 1596588) for ESlint failures in android/modules/geckoview/GeckoViewPushController.jsm. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277003026&repo=autoland&lineNumber=209

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=277003026&revision=21632bd4c4cac3b1140066b8a4b790ecd0ee602e

Backout:
https://hg.mozilla.org/integration/autoland/rev/76bf3e0a2f630b4f6b1fb5cd0d5aaf6a8d89d346

Comment 5

[Jonathan Almeida [:jonalmeida]]

Sorry about that Dorel. I've fixed the eslint errors. I'll make it a pre-push hook for myself next time.

I missed that in my previous try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=473b0b798a90a19239a4e1603a0fa00305f79a29&selectedJob=276510590

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6294fecb7978
Update WebPushController.onPushEvent to take only the scope. r=snorp

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6294fecb7978