1596665 - [fission] Remove nsIWritablePropertyBag/nsIWritablePropertyBag2 support from DocumentChannelChild

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Jean-Yves Avenard [:jya]]

DocumentChannelChild implements nsIWritablePropertyBag/nsIWritablePropertyBag2 via nsHashPropertyBag.

Those properties are set by nsDocShell in the content process and aren't passed to the parent.

If a change of process occurs the nsIChannel in the new content process won't have those properties set.

Currently this problem is hidden as the test only occurs where there's no process switch involved.

We do not need to set those properties on the DocumentChannel (neither Child nor Parent) ; only on the final channel. We should transmit those over IPC instead.

By removing nsHashPropertyBag inheritance from DocumentChannelChild we can simplify it and make those tests work with fission.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1596665 - P1. Add IPDL serializer for nsHasPropertyBag/nsIVariant. r?mattwoodrow

Only nsIURI are handled for the nsIVariant::GetAsInterface().

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1596665 - P2. Add ability to copy all property bag contents to another. r?mattwoodrow

Depends on D53922

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1596665 - P3. Copy property bag from parent to child. r?kmag!,mayhemer!

Rather that setting the property bag on both the child and parent from the docshell; we first set it on the parent instead, and once the redirect (or process switch) has completed we carry that bag across.

Depends on D53923

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1596665 - P4. Expose some nsDocShell utility methods. r?kmag

Depends on D53924

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1596665 - P5. Pass last site information from the parent and remove DCC's nsHashPropertyBag inheritance. r?kmag!,mayhemer!

The previous site URI is now only written on the parent and sent back to the child once all redirects have completed.

In a follow up we will also transfer this information when a process switch occur as it's currently broken.

Depends on D53925

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d328964a7526
P1. Add IPDL serializer for nsHasPropertyBag/nsIVariant. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/452793927396
P2. Add ability to copy all property bag contents to another. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/4bd5a9363b0d
P3. Copy property bag from parent to child. r=kmag,mayhemer
https://hg.mozilla.org/integration/autoland/rev/4949c8e7623b
P4. Expose some nsDocShell utility methods. r=kmag
https://hg.mozilla.org/integration/autoland/rev/5ccb0dc150d1
P5. Pass last site information from the parent and remove DCC's nsHashPropertyBag inheritance. r=mayhemer,kmag

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d328964a7526
https://hg.mozilla.org/mozilla-central/rev/452793927396
https://hg.mozilla.org/mozilla-central/rev/4bd5a9363b0d
https://hg.mozilla.org/mozilla-central/rev/4949c8e7623b
https://hg.mozilla.org/mozilla-central/rev/5ccb0dc150d1