1599006 - [fission] Redirect page history and frecency data not passed around when process switching

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Jean-Yves Avenard [:jya]]

Work to fix this issue started with bug 1596665/

If cross-origin redirects occur, the page history and frecency data will not be passed to the new content process.

This can be verified by tweaking the tests in toolkit/components/places/tests/browser/ so that a cross-origin redirect occurs.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1599006 - P1. Use cross-origin redirects to exercise fission code. r?mak

By making the final redirect use a cross-origin destination we can exercise the fission code and expose issues.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1599006 - P2. Fix namespace comment. r?mattwoodrow

Depends on D54454

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1599006 - P3. Fix move semantics. r?mattwoodrow

A typo prevented for moves to actually occur. Fix other IPDL entry points while at it that could benefit from move semantics.

Depends on D54907

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1599006 - P4. Properly carry history and frecency data when switching process. r=kmag!,mayhemer.

This allows test toolkit/components/places/tests/browser/browser_multi_redirect_frecency.js and others to pass when fission is enabled.

The content process expects to know the chain of redirects encountered while opening a URI. The DocumentChannelParent gather that information and sends it to the new ContentChild which can then propagate the information to the new nsDocShell.

The data used to only be passed around during same-origin redirects when fission mode was enabled.

In order to allow for move semantics and preventing unnecessary copy of the DocumentChannelRedirect array, we make the nsIChildProcessChannelListener::onChannelReady property C++ only (noscript).
As we have only one concrete nsIChildProcessChannelListener class (ChildProcessListener) and that the unique OnChannelReady implementation is infallible; we really don't need for the method to return nsresult (so we declare it nostdcall). This helps simplify that call.

Depends on D54908

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b115cb4fce6
P1.  Use cross-origin redirects to exercise fission code. r=mak
https://hg.mozilla.org/integration/autoland/rev/578557e3b952
P2. Fix namespace comment. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/7531b31fc05a
P3. Fix move semantics. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/b87b36262b01
P4. Properly carry history and frecency data when switching process. r=kmag,mayhemer.

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9b115cb4fce6
https://hg.mozilla.org/mozilla-central/rev/578557e3b952
https://hg.mozilla.org/mozilla-central/rev/7531b31fc05a
https://hg.mozilla.org/mozilla-central/rev/b87b36262b01