1596894 - Update GMP fallback downloader for Widevine CDM 4.10.1582.2

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Once we're serving the new CDM via balrog we should update the fallback downloader to match.

For reference bug 1566180 is the last time this was done.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I notice that our balrog rules include an alias:

"Linux_x86_64-gcc3-asan": {
  "alias": "Linux_x86_64-gcc3"
},

The fallback downloader rules have omitted this since it was introduced last year. I'm going to piggy back on these changes to add this alias so the fallback rules cover this case.

Script to generate the fallback json incoming as well as patch.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Python 3 script used to generate file. Requires requests lib

Attaching script I used to generate the json so my working can be checked. Compare script output to https://aus-api.mozilla.org/api/v1/releases/Widevine-4.10.1582.2 to further verify. They should match except that the script omits outputting the a product field as it's redundant.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1596894 - Update fallback GMP downloader for Widevine 4.10.1582.2. r?rhelmer

Update the GMP fallback downloader for Widevine to reference the 4.10.1582.2
CDM. This keeps the fallback URLs in step with Balrog.

Add an alias for Linux_x86_64-gcc3-asan to Linux_x86_64-gcc3. This alias
exists in the Balrog rules already. This covers the case where the fallback is
needed for such asan builds.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bcc3ff9edb4
Update fallback GMP downloader for Widevine 4.10.1582.2. r=rhelmer

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5bcc3ff9edb4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this ready for an ESR68 approval request?

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Is this ready for an ESR68 approval request?

Almost. Let me get the balrog rules updated and then I'll request this.

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9116883 [details]
Bug 1596894 - Update fallback GMP downloader for Widevine 4.10.1582.2. r?rhelmer

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This keeps the Widevine fallback updater in line with the Balrog rules and is part of keeping Widevine updated in ESR.
• User impact if declined: Users may be served a non-current version of Widevine. It's possible this version may be deactivated in the future and thus would not longer decode media, so we want to keep the versions up to date.
• Fix Landed on Version: 73
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small and well understood change that is only used if balrog is down.
• String or UUID changes made by this patch: None.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9116883 [details]
Bug 1596894 - Update fallback GMP downloader for Widevine 4.10.1582.2. r?rhelmer

widevine update for 68.5esr

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/6e380e9e61a1

Comment 11

[Diana Rus]

Hi, should testing this be taken in consideration? I did not manage to find in the approval request whether there is the need or not for qa to test this issue.

Comment 12

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

(In reply to Diana Rus from comment #11)

Hi, should testing this be taken in consideration? I did not manage to find in the approval request whether there is the need or not for qa to test this issue.

Ideally, yes. It's not of critical importance, but would be helpful to test.

The changes here can be tested by the following:

• set the media.eme.enabled pref to false. This will ensure EME is disabled and the CDM removed.
• set the media.gmp-manager.url.override pref to a bad URL, e.g. garbage (this pref does not exist by default so will need to be created). The will cause the normal update service to fail because it will try and contact the server at the bad URL.
• set the media.eme.enabled pref to true.
• visit a site that uses EME and check the CDM is installed. We would expect the Widevine CDM to still be installed in this case using the fallback downloader URL.