1596981 - Fission: JS errors running automated tests - InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable" {file: "resource:///actors/ContentMetaChild.jsm line 167}

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[:Gijs (he/him)]

ContentMetaChild.jsm seems like it creates a timer at https://searchfox.org/mozilla-central/rev/b58e44b74ef2b4a44bdfb4140c2565ac852504be/browser/actors/ContentMetaChild.jsm#160-167 and then by the time the timer fires, it's possible the actor has become dead, which throws errors.

We should catch this case somehow.

Seen both locally and on infra when applying my patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1586139

Comment 1

[:Gijs (he/him)]

Example raw log: https://firefoxci.taskcluster-artifacts.net/SOM1ddYwSn6E34W7Xu78BA/0/public/logs/live_backing.log (though I don't think it really has much more useful data to go on. :-( )

from https://treeherder.mozilla.org/#/jobs?repo=try&revision=e72b0953d8021901b456cc741290b97d504ea081&selectedJob=276436013

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:thecount, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Chris Peterson [:cpeterson]]

Neil, this bug is a blocker for Fission's current milestone (M4.1 aka "fix all the mochitests"), but it's currently unassigned. The Fission team is hoping teams will fix their mochitests for Fission before the end of Q1 (75 or 76 Nightly).

Will your team be able to prioritize this bug for Q1? If you don't think this mochitest failure should block shipping Fission, just let me know.

If you have questions for Fission engineers, you can reach them in the #fission channel on Slack or Riot.

Comment 6

[:Gijs (he/him)]

I've just written up a fix here, but just to check, does it really make sense for this to block M4.1 ? I don't think any tests are not passing, it's just log errors.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1596981 - catch the case where actors go away while a timer is pending in ContentMetaChild.jsm, r?neildeakin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8281579dbb8b
catch the case where actors go away while a timer is pending in ContentMetaChild.jsm, r=NeilDeakin

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8281579dbb8b

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to :Gijs (he/him) from comment #6)

I've just written up a fix here, but just to check, does it really make sense for this to block M4.1 ? I don't think any tests are not passing, it's just log errors.

In that case, I will clear the Fission Milestone. Since these errors didn't break any tests, fixing them would not necessarily block any particular Fission milestone.