Closed Bug 1597237 Opened 1 year ago Closed 11 months ago

Remove useless return; declaration

Categories

(Core :: General, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: Sylvestre, Assigned: walshd9, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=C++])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1597214 +++

+++ This bug was initially created as a clone of Bug #1592270 +++

Filling as a good first bug to learn workflows.

As return; is at the end of a void function, the declaration is useless
https://searchfox.org/mozilla-central/source/dom/events/DataTransfer.cpp#738

As the change is trivial, it is just to learn how to contribute to Firefox.

Hi, getting familiar with the contribution process looking for a first bug fix. I'd like to take on the bug.

Flags: needinfo?(sledru)

walshd9 is working on it (but I will unassigned it if no progress in a few days)
Send me an email if you want me to open a new bug for you

Flags: needinfo?(sledru)

Hi, sorry about the delay, I've had a lot of emails coming in from mozilla and have had to slowly filter through them. I'll get on this over the weekend. From reading above, all that is needed is the remove of the one return statement. Is this correct? Cheers

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf4e71881270
Remove useless return; declaration, r=sylvestre
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.