1597372 - Print Preview hides the window titlebar

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot of problem.

STR:

1. Load any web page
2. Go to the App Menu, and choose Print to open Print Preview.

ER:

Tabs should collapse, but the main window controls (with the window title, minimize, maximize and close) should be shown.

AR:

See screenshot.

Mozregression points at bug 1492582 (this push, specifically: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=038ebfdd141acdc7603d2378a832a572bb267686&tochange=9644ee96a51a03a8f4e50e9777fb7278f246383c)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey bdahl,

Any idea how bug 1492582 might have caused this?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

Asking for tracking since this is visually pretty bad, and we shouldn't let it ride.

Comment 3

[Brendan Dahl [:bdahl]]

I think this is the same as bug 1596709. We need to respond to some root element attributes that were previously handled by XUL element.

Comment 4

[Jim Mathies [:jimm]]

Code freeze coming u[ on monday.

Comment 5

[Brendan Dahl [:bdahl]]

Will be fixed by bug 1596709.

Comment 6

[Cristian Fogel [:cfogel]]

Confirmed issue with 72.0a1 (2019-11-18).
Fix verified with 72.0b5 on Windows 10, Ubuntu 19.04. The PDF preview for macOS 10.15 is Ok as well.