1597376 - Style the about:profiling page to match other settings pages

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Greg Tatum [:gregtatum]]

The first step in Bug 1597373 is to create a minimal about:profiling page. This bug is about styling and changing the look of the new page to match the UX work. There will probably be additional follow-ups to this, but this bug will serve to track the initial styling work. I am guessing that we will still support the old popup methods concurrently.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1597376 - Break out profiler event handling into a separate component; r?julienw

Depends on D54771

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1597376 - Change the isPopup flag to a PageContext; r?julienw

The new about:profiling page creates some more complexity around what
the page context is. It is simpler to handle the different cases with
a union, rather than booleans.

Depends on D55007

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1597376 - Make the summary dropdowns conditional in the profiler settings; r?julienw

This is probably the biggest change to the existing components, as it makes the
summary dropdowns conditional based on the page context. This keeps the old
workflow working, but allows for the new about:profiling page's design. Most
of the diff here is creating the new _renderSection method which consolidates
this logic, and also handles the summary div structure.

Depends on D55008

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1597376 - Implement the new about:profiling page; r?julienw

This patch adds a new context for the performance-new components. It's
eventually the only place where the settings will live, but for now
the components share the settings between the popup, the devtools panel,
and the about:profiling page.

This page uses the base styling that the preferences page uses. The styles
should obey the theming for the browser, and ignore the devtools theming
colors.

Depends on D55009

Comment 5

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ff1517a94f14053ecaea203bbe885c3461b783d

Comment 6

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=275891900b64f81384b6bc88b4b2f0950db5072a

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/145bc8015c6c
Break out profiler event handling into a separate component; r=julienw
https://hg.mozilla.org/integration/autoland/rev/76055c79cada
Change the isPopup flag to a PageContext; r=julienw
https://hg.mozilla.org/integration/autoland/rev/a0076bbce8f9
Make the summary dropdowns conditional in the profiler settings; r=julienw
https://hg.mozilla.org/integration/autoland/rev/abb73036e3ae
Implement the new about:profiling page; r=julienw

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 6 changesets (Bug 1597373, Bug 1598320, Bug 1597376) for causing assertion failure in nsContentSecurityUtils.cpp CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=279834183&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=3a6906e644fc5dededf100ca92571b8ccf22a78b&revision=abb73036e3ae7a7625efb14fc3976460bb7ba372

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279834183&repo=autoland&lineNumber=10446

Backout: https://hg.mozilla.org/integration/autoland/rev/930447d78e18bcbf1eccbd90c0bd036417e83fa1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/333a768cf36b
Break out profiler event handling into a separate component; r=julienw
https://hg.mozilla.org/integration/autoland/rev/6d14f9aea069
Change the isPopup flag to a PageContext; r=julienw
https://hg.mozilla.org/integration/autoland/rev/6bfbad8ae53b
Make the summary dropdowns conditional in the profiler settings; r=julienw
https://hg.mozilla.org/integration/autoland/rev/9437a98ef1f1
Implement the new about:profiling page; r=julienw

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/333a768cf36b
https://hg.mozilla.org/mozilla-central/rev/6d14f9aea069
https://hg.mozilla.org/mozilla-central/rev/6bfbad8ae53b
https://hg.mozilla.org/mozilla-central/rev/9437a98ef1f1