1597435 - Fix uses of nsGlobalWindowOuter::SetInitialPrincipalToSubject in dom/base/nsGlobalWindowOuter.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file dom/base/nsGlobalWindowOuter.cpp

Checks type of DocShell.

Change to using BrowsingContext ItemType.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597435 - Fix uses of nsIDocShellTreeItem in nsGlobalWindowOuter::SetInitialPrincipalToSubject.

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I missed bug id...

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597435 - part 2: Fix uses of nsIDocShellTreeItem in nsGlobalWindowOuter::SetInitialPrincipalToSubject.

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597435 - part 1: Update the comment obsoleted by bug 1616353.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d27ee5af31d8
part 1: Update the comment obsoleted by bug 1616353. r=farre

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df5b0da3321a
part 2: Fix uses of nsIDocShellTreeItem in nsGlobalWindowOuter::SetInitialPrincipalToSubject. r=farre

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d27ee5af31d8
https://hg.mozilla.org/mozilla-central/rev/df5b0da3321a