Closed Bug 1597484 Opened 5 years ago Closed 4 years ago

Audit nsIDocShellTreeItem usage in nsPrintObject::InitAsRootObject in layout/printing/nsPrintObject.cpp

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1552966

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple] [layout:triage-discuss])

In file layout/printing/nsPrintObject.cpp

Uses ItemType of existing DocShellTreeItem to create a new BrowsingContext.

Change to get ItemType off of BrowsingContext for the DocShell.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

Please audit this use of the nsIDocShellTreeItem interface. With Fission enabled, Documents and nsDocShells for related frames, such as subframes and parent documents, may not be available within the current process and the corresponding nsIDocShellTreeItem methods will return null.

If this code is broken with Fission, fixing it blocks enabling Fission is Nightly and your team should prioritize (or delegate) the fix accordingly.

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

Fission documentation about replacing nsIDocShellTree Item:
https://wiki.mozilla.org/Project_Fission/DocShell_Tree_Replace

:farre's presentation with examples of replacing nsIDocShellTreeItem with BrowsingContext, WindowContext, SyncedContexts, and BrowsingContextGroup:
https://docs.google.com/presentation/d/1K4j6ngty64TZjJNS5qH-MBoOm3TI2dJedVsbH8jUhKE/edit#slide=id.g6e35225e5d_1_264

Component: DOM: Navigation → Layout
Priority: P3 → --
Summary: Fix uses of nsPrintObject::InitAsRootObject in layout/printing/nsPrintObject.cpp → Audit nsIDocShellTreeItem usage in nsPrintObject::InitAsRootObject in layout/printing/nsPrintObject.cpp
Whiteboard: [rm-docshell-tree-item:simple] → [rm-docshell-tree-item:simple] [layout:triage-discuss]Please audit this use of the nsIDocShellTreeItem interface. With Fission enabled, Documents and nsDocShells for related frames, such as subframes and parent documents, may not be available within the c…

The priority flag is not set for this bug.
:dbaron, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dbaron)
Whiteboard: [rm-docshell-tree-item:simple] [layout:triage-discuss]Please audit this use of the nsIDocShellTreeItem interface. With Fission enabled, Documents and nsDocShells for related frames, such as subframes and parent documents, may not be available within the c… → [rm-docshell-tree-item:simple] [layout:triage-discuss]

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Fission Milestone: M6 → M6c
Blocks: 1557645

I believe this was fixed by bug 1552966.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(dbaron)
Resolution: --- → DUPLICATE

Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.

Fission Milestone: M6c → ---
You need to log in before you can comment on or make changes to this bug.