Open Bug 1597491 Opened 2 years ago Updated 1 year ago

Remove nsIDocShellTreeItem usage in nsXULPopupManager::MayShowPopup in layout/xul/nsXULPopupManager.cpp

Categories

(Core :: XUL, defect, P3)

defect

Tracking

()

Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

In file layout/xul/nsXULPopupManager.cpp

Tests whether it is OK to show a popup or not, given an nsMenuPopupFrame.

Gets BaseWindow by QueryInterfacing PresContext->DocShell.

Gets root-window for in-process root.

It seems like this would be running in chrome context all the time, so out-of-process documents and windows are not an issue.

Change code to using BrowsingContext to navigate tree.

Assert that all relevant BrowsingContext items (and windows) are in-process.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

Henri, you changed nsXULPopupManager::MayShowPopup to using BrowsingContext in bug 1618163. Does that change also fix bug?

I see there are still some uses of nsIDocShellTreeItem in nsXULPopupManager.cpp.

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

Component: DOM: Navigation → XUL
Flags: needinfo?(hsivonen)
Priority: P3 → --
Summary: Fix uses of nsXULPopupManager::MayShowPopup in layout/xul/nsXULPopupManager.cpp → Audit nsIDocShellTreeItem usage in nsXULPopupManager::MayShowPopup in layout/xul/nsXULPopupManager.cpp
Priority: -- → P3

(In reply to Chris Peterson [:cpeterson] from comment #2)

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

I believe we don't need to change nsXULPopupManager::MayShowPopup for MVP. The relevant usage is in the chrome process.

Flags: needinfo?(hsivonen)
Fission Milestone: M6 → Future
Summary: Audit nsIDocShellTreeItem usage in nsXULPopupManager::MayShowPopup in layout/xul/nsXULPopupManager.cpp → Remove nsIDocShellTreeItem usage in nsXULPopupManager::MayShowPopup in layout/xul/nsXULPopupManager.cpp

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(enndeakin)
Severity: normal → S4
Flags: needinfo?(enndeakin)
You need to log in before you can comment on or make changes to this bug.