1597491 - Remove nsIDocShellTreeItem usage in nsXULPopupManager::MayShowPopup in layout/xul/nsXULPopupManager.cpp

Status: NEW

(Core :: XUL, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file layout/xul/nsXULPopupManager.cpp

Tests whether it is OK to show a popup or not, given an nsMenuPopupFrame.

Gets BaseWindow by QueryInterfacing PresContext->DocShell.

Gets root-window for in-process root.

It seems like this would be running in chrome context all the time, so out-of-process documents and windows are not an issue.

Change code to using BrowsingContext to navigate tree.

Assert that all relevant BrowsingContext items (and windows) are in-process.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Chris Peterson [:cpeterson]]

Henri, you changed nsXULPopupManager::MayShowPopup to using BrowsingContext in bug 1618163. Does that change also fix bug?

I see there are still some uses of nsIDocShellTreeItem in nsXULPopupManager.cpp.

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

Comment 3

[Henri Sivonen (:hsivonen)]

(In reply to Chris Peterson [:cpeterson] from comment #2)

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

I believe we don't need to change nsXULPopupManager::MayShowPopup for MVP. The relevant usage is in the chrome process.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit auto_nag documentation.