1618163 - Use BrowsingContext for activeness check in nsXULPopupManager::MayShowPopup

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Henri Sivonen (:hsivonen)]

Use BrowsingContext in content processes for Fission.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1618163 - Use BrowsingContext for activeness check in nsXULPopupManager::MayShowPopup.

Comment 2

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3da6e2a73f85463ba4b9e32739fdbd2fdbd2ded0

Comment 3

[Henri Sivonen (:hsivonen)]

Asserting chrome-processness instead:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7126d20318eac76431e703c132f9e30f6aea520d

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1beef00f147f
Use BrowsingContext for activeness check in nsXULPopupManager::MayShowPopup. r=NeilDeakin

Comment 5

[Henri Sivonen (:hsivonen)]

Filed bug 1619240.

Comment 6

[Oana Pop-Rus]

Backed out changeset 1beef00f147f (bug 1618163) for build bustages in nsXULPopupManager.cpp

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=1beef00f147ff9d418b8f20850913f02fb1687ff&selectedJob=291244675

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291244675&repo=autoland&lineNumber=24484

Backout: https://hg.mozilla.org/integration/autoland/rev/26b3977a76d1dfca4e8a9e68b8b386896c9bb050

Comment 7

[Henri Sivonen (:hsivonen)]

This should fix the Mac build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4e7df11f776b6a4a342089d8fe94bb8889736c3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7513fc59f07
Use BrowsingContext for activeness check in nsXULPopupManager::MayShowPopup. r=NeilDeakin

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a7513fc59f07

Comment 10

[Chris Peterson [:cpeterson]]

M5