Cleanup uses of js::detail::CopyScript
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(4 files)
Fix up some of the script cloning pathways to be a bit more uniform. The aim is to reduce the number of partial initialization states for scripts and to simplify onNewScript callbacks.
Assignee | ||
Comment 1•4 years ago
|
||
Instead of using cloneSelfHostedFunctionScript
and then partially undoing
the result, create the JSFunction and use CloneScriptIntoFunction directly.
This avoids initializing fields to wrong values and fixing later.
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D53873
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d89e4585eefa Call onNewScript from CloneGlobalScript. r=caroline
Comment 4•4 years ago
|
||
bugherder |
Assignee | ||
Comment 5•4 years ago
|
||
Now that we directly construct the JSFunction of a default constructor, we
set the name and flags correctly. As a result the MakeDefaultConstructor
intrinsic doesn't do anything of consequence and we can remove it.
Depends on D53873
Assignee | ||
Comment 6•4 years ago
|
||
If we add JSScript::initSharedData(), we no longer need to mark CopyScript as
a friend of JSScript and can simplify some things.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97deb8f0cd01 Call CloneScriptIntoFunction directly from MakeDefaultConstructor. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/becfcaa1a8e5 Remove MakeDefaultConstructor intrinsic. r=mgaudet
Comment 8•4 years ago
|
||
bugherder |
Assignee | ||
Updated•4 years ago
|
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65b612924b35 Stop requiring js::detail::CopyScript to be a friend. r=caroline
Comment 10•4 years ago
|
||
bugherder |
Description
•