1597795 - Cleanup uses of js::detail::CopyScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Fix up some of the script cloning pathways to be a bit more uniform. The aim is to reduce the number of partial initialization states for scripts and to simplify onNewScript callbacks.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1597795 - Call CloneScriptIntoFunction directly from MakeDefaultConstructor. r?mgaudet

Instead of using cloneSelfHostedFunctionScript and then partially undoing
the result, create the JSFunction and use CloneScriptIntoFunction directly.
This avoids initializing fields to wrong values and fixing later.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1597795 - Call onNewScript from CloneGlobalScript. r?caroline

Depends on D53873

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d89e4585eefa
Call onNewScript from CloneGlobalScript. r=caroline

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d89e4585eefa

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1597795 - Remove MakeDefaultConstructor intrinsic. r?mgaudet

Now that we directly construct the JSFunction of a default constructor, we
set the name and flags correctly. As a result the MakeDefaultConstructor
intrinsic doesn't do anything of consequence and we can remove it.

Depends on D53873

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: Bug 1597795 - Stop requiring js::detail::CopyScript to be a friend. r?caroline

If we add JSScript::initSharedData(), we no longer need to mark CopyScript as
a friend of JSScript and can simplify some things.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97deb8f0cd01
Call CloneScriptIntoFunction directly from MakeDefaultConstructor. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/becfcaa1a8e5
Remove MakeDefaultConstructor intrinsic. r=mgaudet

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/97deb8f0cd01
https://hg.mozilla.org/mozilla-central/rev/becfcaa1a8e5

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65b612924b35
Stop requiring js::detail::CopyScript to be a friend. r=caroline

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/65b612924b35