1597860 - Cannot build esr-68 locally with the toolchain installed from mozilla-central builds

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[(no longer active)]

I get errors like this:

 1:48.91 error: `...` range patterns are deprecated
 1:48.91    --> modules/libpref/parser/src/lib.rs:632:25
 1:48.91     |
 1:48.91 632 |                 c @ b'0'...b'9' => value += (c - b'0') as u16,
 1:48.91     |                         ^^^ help: use `..=` for an inclusive range
 1:48.92     |
 1:48.92     = note: `-D ellipsis-inclusive-range-patterns` implied by `-D warnings`
 1:48.92 error: `...` range patterns are deprecated
 1:48.92    --> modules/libpref/parser/src/lib.rs:633:25
 1:48.92     |
 1:48.92 633 |                 c @ b'A'...b'F' => value += (c - b'A') as u16 + 10,
 1:48.92     |                         ^^^ help: use `..=` for an inclusive range
 1:48.92 error: `...` range patterns are deprecated
 1:48.92    --> modules/libpref/parser/src/lib.rs:634:25
 1:48.92     |
 1:48.92 634 |                 c @ b'a'...b'f' => value += (c - b'a') as u16 + 10,
 1:48.92     |                         ^^^ help: use `..=` for an inclusive range
 1:49.05    Compiling mozilla-central-workspace-hack v0.1.0 (/home/ehsan/moz/1527287/build/workspace-hack)
 1:49.10 error: aborting due to 3 previous errors
 1:49.11 error: Could not compile `prefs_parser`.
 1:49.11 warning: build failed, waiting for other jobs to finish...

and

 2:05.30 error: trait objects without an explicit `dyn` are deprecated
 2:05.30   --> testing/mozbase/rust/mozprofile/src/prefreader.rs:17:28
 2:05.30    |
 2:05.31 17 |         parent: Option<Box<Error>>,
 2:05.31    |                            ^^^^^ help: use `dyn`: `dyn Error`
 2:05.31    |
 2:05.31    = note: `-D bare-trait-objects` implied by `-D warnings`
 2:05.31 error: trait objects without an explicit `dyn` are deprecated
 2:05.31   --> testing/mozbase/rust/mozprofile/src/prefreader.rs:42:32
 2:05.31    |
 2:05.31 42 |     fn cause(&self) -> Option<&Error> {
 2:05.31    |                                ^^^^^ help: use `dyn`: `dyn Error`
 2:05.31 error: trait objects without an explicit `dyn` are deprecated
 2:05.32    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:146:24
 2:05.32     |
 2:05.32 146 |     parent: Option<Box<Error>>,
 2:05.32     |                        ^^^^^ help: use `dyn`: `dyn Error`
 2:05.32 error: `...` range patterns are deprecated
 2:05.32    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:361:28
 2:05.32     |
 2:05.32 361 |                         '0'...'9' => value += x as u32 - '0' as u32,
 2:05.32     |                            ^^^ help: use `..=` for an inclusive range
 2:05.32     |
 2:05.32     = note: `-D ellipsis-inclusive-range-patterns` implied by `-D warnings`
 2:05.32 error: `...` range patterns are deprecated
 2:05.32    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:362:28
 2:05.32     |
 2:05.32 362 |                         'a'...'f' => value += x as u32 - 'a' as u32,
 2:05.32     |                            ^^^ help: use `..=` for an inclusive range
 2:05.32 error: `...` range patterns are deprecated
 2:05.32    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:363:28
 2:05.33     |
 2:05.33 363 |                         'A'...'F' => value += x as u32 - 'A' as u32,
 2:05.33     |                            ^^^ help: use `..=` for an inclusive range
 2:05.33 error: `...` range patterns are deprecated
 2:05.33    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:597:24
 2:05.33     |
 2:05.33 597 |                     '0'...'9' | '-' | '+' => {
 2:05.33     |                        ^^^ help: use `..=` for an inclusive range
 2:05.33 error: `...` range patterns are deprecated
 2:05.33    --> testing/mozbase/rust/mozprofile/src/prefreader.rs:648:24
 2:05.33     |
 2:05.33 648 |                     '0'...'9' => TokenizerState::Number,
 2:05.33     |                        ^^^ help: use `..=` for an inclusive range
 2:05.33    Compiling flate2 v1.0.1
 2:05.58 error: aborting due to 8 previous errors
 2:05.59 error: Could not compile `mozprofile`.
 2:05.59 warning: build failed, waiting for other jobs to finish...
 2:35.43 error: build failed

Comment 1

[Mike Hommey [:glandium]]

Don't build with --enable-warnings-as-errors.

Comment 2

[(no longer active)]

Oh, good point.