1597932 - Remove broken #tabbrowser-tabs[movingtab] > .tabbrowser-tab selector

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Dão Gottwald [:dao]]

Bug 1555060 broke this selector:

https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/browser/base/content/browser.css#238

It needs to use #tabbrowser-tabs[movingtab] > .tabbrowser-arrowscrollbox > ....

I'm not sure what exactly broke here from a user's perspective. :/

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Getting late for 72, but we could still take a patch for 73.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Following up in Slack/email but I'm also marking this fix-optional for 74 to remove it from regression triage.

Comment 3

[Andrew Swan [:aswan]]

I can write a patch to fix the selector but from playing with this briefly I'm not able to see any difference with and without the selector being fixed. Dão can you tell me if I'm reading this correctly: it looks to me like the "fadein" attribute is only present on tabs that are being added to a particular tabstrip, so this selector which is a tab with the "fadein" attribute inside a tabstrip with the "movingtab" attribute would apply to a tab being moved from one window to another? I don't see any animation in this case so I'm not sure what effect the rule is meant to have...

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1597932 Remove obsolete tabbrowser-tab selector r?dao

This was inadveretently broken by bug 1555060.

Comment 5

[Andrew Swan [:aswan]]

Incidentally, that selector seems to have come originally from bug 783282, though the title of that bug is about "dragging a tab within the tab strip". I haven't had a chance to read that bug/patch in more detail to try to sort this out...

Comment 6

[Marco Castelluccio [:marco]]

The bot was updating the type to "defect" because the bug was marked as a regression. In the future it might even be enforced by Bugzilla itself.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/789764012610
Remove obsolete tabbrowser-tab selector r=dao

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/789764012610