1598041 - Switching between IMAP and Exchange options hides error message when IMAP fails

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[[e-mail]]

If Thunderbird offers both IMAP and Exchange, then if you toggle between the two, and you don't yet have any add-ons installed, then the status area gets hidden, and no error message is displayed if your attempt to configure an IMAP account fails.

Comment 1

[Ben Bucksch (:BenB)]

e("result_select_" + alt.type).configIncoming = alt;

I also got a e(...) is null error on this line (during my testing of bug 1592258), if I had options before and they are no longer available.

Comment 2

[[e-mail]]

Attachment: Proposed patch

The other alternative would be to show the status-area when switching back to IMAP, but this way is slightly nicer UI.

Comment 3

[Ben Bucksch (:BenB)]

Comment on attachment 9110299 [details] [diff] [review]
Proposed patch

r+

I concur for the same reasons. We should not hide the error message that might be there. It's also nice to see where the config came from.

Comment 4

[Ben Bucksch (:BenB)]

Tested and fixes the bug for me.
Please land.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4498a8428f41
Don't hide error message when offering addon r=BenB

Comment 6

[Ben Bucksch (:BenB)]

Thanks, Geoff :)

Comment 7

[[e-mail]]

Comment on attachment 9110299 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): Exposed by bug 1571772, since that created a previously unavailable UI combination
User impact if declined: Confusing display in certain cases
Testing completed (on c-c, etc.): n/a
Risk to taking this patch (and alternatives if risky): No risk, removal of unnecessary code.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9110299 [details] [diff] [review]
Proposed patch

Do it!

Comment 9

[Geoff Lankow (:darktrojan)]

71 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/cc97a8435bb674f47022d1b61e70ac0e54730b32

Comment 10

[[e-mail]]

Attachment: ESR port

Trivial 1-character change.

[Approval Request Comment]
Regression caused by (bug #): Exposed by bug 1571772, since that created a previously unavailable UI combination
User impact if declined: Confusing display in certain cases
Testing completed (on c-c, etc.): n/a
Risk to taking this patch (and alternatives if risky): No risk, removal of unnecessary code.

Comment 11

[Magnus Melin [:mkmelin]]

Ben, Neil: please no cross-reviewing by you two on account setup. There's a feedback flag so please use that instead.
(Not that it matters much for this bug.)

Comment 12

[Geoff Lankow (:darktrojan)]

68.3.1:
https://hg.mozilla.org/releases/comm-esr68/rev/32771f224f8378967a3dd0ee30c1985847701d6c