Closed
Bug 1598317
Opened 6 years ago
Closed 6 years ago
Add tests for export options in Changes panel
Categories
(DevTools :: Inspector: Changes, task, P2)
DevTools
Inspector: Changes
Tracking
(firefox73 fixed)
RESOLVED
FIXED
Firefox 73
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The export options from the Changes panel are not covered by any tests.
When they break, we don't know about it, as evidenced by Bug 1598007.
Add tests for the following operations:
- Copy Rule button
- Copy All Changes button
- Copy Rule context menu option
- Copy Declaration context menu option
|
Assignee | |
Updated•6 years ago
|
Summary: Add tests for Copy buttons in Changes panel → Add tests for export options in Changes panel
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Make ChangesContextMenu directly extend Menu instead of wrapping it so external objects and tests can listen to its events.
Reduce ChangesContextMenu's knowledge about the outside world (like ChangesView) by providing it in the constructor with the callbacks necessary for each context menu item.
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a5d482dbf07
Refactor Changes panel context menu. r=pbro
https://hg.mozilla.org/integration/autoland/rev/6fb59213fc03
Add tests for Changes panel export options. r=pbro
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1a5d482dbf07
https://hg.mozilla.org/mozilla-central/rev/6fb59213fc03
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox73:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
You need to log in
before you can comment on or make changes to this bug.
Description
•