1598585 - Crash in [@ mozilla::gfx::Factory::SetDirect3D11Device]

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Looks like a race between the canvas threads and this being created on the main thread.
Also, might be the device failing and being recreated on the canvas thread.

This bug is for crash report bp-d03d8b74-a35b-4357-9c15-5f4df0191122.

Top 10 frames of crashing thread:

0 xul.dll mozilla::gfx::Factory::SetDirect3D11Device gfx/2d/Factory.cpp:816
1 xul.dll mozilla::gfx::DeviceManagerDx::CreateCanvasDevice gfx/thebes/DeviceManagerDx.cpp:305
2 xul.dll mozilla::gfx::DeviceManagerDx::GetCanvasDevice gfx/thebes/DeviceManagerDx.cpp:1141
3 xul.dll static class mozilla::layers::TextureData* mozilla::layers::CreateTextureData gfx/layers/CanvasTranslator.cpp:33
4 xul.dll struct already_AddRefed<mozilla::gfx::DrawTarget> mozilla::layers::CanvasTranslator::CreateDrawTarget gfx/layers/CanvasTranslator.cpp:175
5 xul.dll mozilla::gfx::RecordedDrawTargetCreation::PlayEvent gfx/2d/RecordedEventImpl.h:1803
6 xul.dll static bool mozilla::gfx::RecordedEvent::DoWithEvent<mozilla::gfx::EventRingBuffer> gfx/2d/RecordedEventImpl.h:3586
7 xul.dll mozilla::layers::CanvasTranslator::TranslateRecording gfx/layers/CanvasTranslator.cpp:83
8 xul.dll void mozilla::layers::CanvasParent::StartTranslation gfx/layers/ipc/CanvasParent.cpp:191
9 xul.dll nsresult mozilla::detail::RunnableMethodImpl< xpcom/threads/nsThreadUtils.h:1176

Comment 1

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Looks like these are all the canvas thread trying to recreate the device after a device reset.
I think we probably need to:

• detect that instead of trying to recreate the device
• notify of device reset for the device to be recreated on the main thread
• handle any errors and wait for everything to be recreated
• probably add a critical note at some point

Comment 2

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1598585 Part 1: Make CanvasTranslator the PCanvas parent actor. r=mattwoodrow!

We want to be able to send IPC message from the translation in the parent. So
the simplest thing it move the top level actor parts of CanvasParent into
CanvasTranslator.
This patch also moves the canvas thread management parts out into a new
CanvasThreadHolder class and hopefully makes the lifecycle management of these
much more robust. This includes the use of a TaskQueue per CanvasTranslator to
manage serial processing on the canvas workers, instead of a boolean.

Comment 3

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1598585 Part 2: Make playback of Moz2D recorded events more robust. r=jrmuizel!

This is generally around object creation failures and their subsequent lookup,
which can happen, for example, during device reset.

Depends on D60887

Comment 4

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1598585 Part 3: Detect and handle device reset in CanvasTranslator. r=jrmuizel!

Depends on D60888

Comment 5

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1598585 Part 4: Notify the content process of a canvas device change. r=jrmuizel!

This sends a message to the content process on device reset/change. The content process clears the CanvasImageCache and canvas TextureClients and the records a
new event, so the translator knows it has finished.

Depends on D60889

Comment 6

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&duplicate_jobs=visible&revision=3f4944bc654c383e4447d75e90774a90a4a40e95

Another with remote canvas enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&duplicate_jobs=visible&revision=12b9c783ec17e06d601f686e4c2185984778b23c

Comment 7

[Bob Owen (:bobowen) (PTO until 5th Oct)]

Attachment: Bug 1598585 Part 5: Create a new reference texture on canvas device change. r=jrmuizel!

Depends on D60890

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b300b00fc72
Part 1: Make CanvasTranslator the PCanvas parent actor. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/95d4eb6763c2
Part 2: Make playback of Moz2D recorded events more robust. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/084d739fe6af
Part 3: Detect and handle device reset in CanvasTranslator. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/4ec0aa2e5a72
Part 4: Notify the content process of a canvas device change. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8ec087144347
Part 5: Create a new reference texture on canvas device change. r=jrmuizel

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6b300b00fc72
https://hg.mozilla.org/mozilla-central/rev/95d4eb6763c2
https://hg.mozilla.org/mozilla-central/rev/084d739fe6af
https://hg.mozilla.org/mozilla-central/rev/4ec0aa2e5a72
https://hg.mozilla.org/mozilla-central/rev/8ec087144347