Closed Bug 1598755 Opened 6 years ago Closed 6 years ago

Remove w3c-css/received/selectors reftests

Categories

(Core :: Layout, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(3 files)

Before removing, we need to investigate the pass/fail state is the same as those in the web-platform-tests, or figuring out why they are different.

Bug 1594937 comment 2 is a sample analysis.

- Run focus-within-*.html on wpt. - Run focus-within-shadow-*.html on reftest. - Run the skipped test, and mark selector-placeholder-shown-type-change-001.html and selector-read-write-type-change-002.html as fails (both are failed in wpt). A try run: https://treeherder.mozilla.org/#/jobs?repo=try&collapsedPushes=532734&revision=6618add4a3cfbd84f3d661250b683a95ec8a54ab

It is unclear to me what kind of instability for them to be disable in
bug 1377588, but we already run them in our own reftest framework. To
remove layout/reftests/w3c-css/selectors/, we'd better run them in wpt.

A try run in bug 1598755 comment 1 shows no orange for these test
running on wpt.

bug 1598755 comment 1 contains an analysis to align wpt's test results
with our own reftest framework, so it is ok to remove these reftests.

In this patch, the manual modifications are

  1. removing os.path.join("selector"), in import-tests.py, and
  2. removing relevant annotations in failures.list.

Others parts are generated by running import-tests.py on a wpt
repository with commit 15f199c91a72b0d51bf0a12b3b77827ecb5051ff.

Depends on D58023

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/372d3c3de0bc Part 1 - Run selectors/focus-within-*.html on wpt. r=dbaron https://hg.mozilla.org/integration/autoland/rev/9c70c427e33d Part 2 - Remove w3c-css/received/selectors reftests. r=dbaron
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: