Closed Bug 1598876 Opened 6 years ago Closed 6 years ago

Intermittent browser/components/newtab/test/browser/browser_discovery_render.js | Got the rendered Message with link text and url within discovery stream - "" == "What’s Pocket?" -

Categories

(Firefox :: New Tab Page, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 74
Tracking Status
firefox73 --- fixed
firefox74 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: thecount)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(2 files)

Filed by: cbrindusan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=277829239&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eY0TSQ5HRbSVN446WTPGvg/runs/0/artifacts/public/logs/live_backing.log


[task 2019-11-23T15:21:34.005Z] 15:21:34 INFO - TEST-START | browser/components/newtab/test/browser/browser_discovery_render.js
[task 2019-11-23T15:21:34.207Z] 15:21:34 INFO - GECKO(8991) | --DOCSHELL 0x7f1c57e99800 == 10 [pid = 8991] [id = {cff1a3a0-aebe-400a-97dc-f23ef2dbae46}] [url = chrome://browser/content/browser.xhtml]
[task 2019-11-23T15:21:34.208Z] 15:21:34 INFO - GECKO(8991) | --DOCSHELL 0x7f1c568a2000 == 9 [pid = 8991] [id = {26134331-fc60-4a77-add7-8740f017ceef}] [url = chrome://browser/content/browser.xhtml]
[task 2019-11-23T15:21:34.209Z] 15:21:34 INFO - GECKO(8991) | --DOCSHELL 0x7f1c53aa7800 == 8 [pid = 8991] [id = {07f3f8e5-5d4b-4d31-ac9d-f5eaf6c118c0}] [url = chrome://browser/content/browser.xhtml]
[task 2019-11-23T15:21:34.210Z] 15:21:34 INFO - GECKO(8991) | --DOCSHELL 0x7f1c56b54000 == 7 [pid = 8991] [id = {0608e406-ccca-462f-b243-3129f032ddea}] [url = chrome://browser/content/browser.xhtml]
[task 2019-11-23T15:21:34.210Z] 15:21:34 INFO - GECKO(8991) | --DOCSHELL 0x7f1c5715b000 == 6 [pid = 8991] [id = {883e3c7e-805a-43cc-af01-2521cf86c584}] [url = chrome://browser/content/browser.xhtml]
[task 2019-11-23T15:21:34.218Z] 15:21:34 INFO - GECKO(8991) | ++DOCSHELL 0x7f18f1807000 == 2 [pid = 9152] [id = {62e89d2c-ba01-431a-aedf-7f9bbac0d6fa}]
[task 2019-11-23T15:21:34.219Z] 15:21:34 INFO - GECKO(8991) | ++DOMWINDOW == 5 (0x7f18f1a3d3e0) [pid = 9152] [serial = 24] [outer = (nil)]
[task 2019-11-23T15:21:34.219Z] 15:21:34 INFO - GECKO(8991) | ++DOMWINDOW == 6 (0x7f18f1896400) [pid = 9152] [serial = 25] [outer = 0x7f18f1a3d3e0]
[task 2019-11-23T15:21:34.294Z] 15:21:34 INFO - GECKO(8991) | ++DOMWINDOW == 7 (0x7f18f1a31400) [pid = 9152] [serial = 26] [outer = 0x7f18f1a3d3e0]
[task 2019-11-23T15:21:34.511Z] 15:21:34 INFO - GECKO(8991) | [Parent 8991, Main Thread] WARNING: NS_ENSURE_TRUE(aPrefName) failed: file /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp, line 2210
[task 2019-11-23T15:21:34.527Z] 15:21:34 INFO - GECKO(8991) | [Parent 8991, Main Thread] WARNING: NS_ENSURE_TRUE(aPrefName) failed: file /builds/worker/workspace/build/src/modules/libpref/Preferences.cpp, line 2210
[task 2019-11-23T15:21:35.310Z] 15:21:35 INFO - GECKO(8991) | --DOMWINDOW == 0 (0x7fcd134ca800) [pid = 9203] [serial = 12] [outer = (nil)] [url = about:newtab]
[task 2019-11-23T15:21:35.427Z] 15:21:35 INFO - GECKO(8991) | --DOMWINDOW == 6 (0x7f18f1a30c00) [pid = 9152] [serial = 20] [outer = (nil)] [url = about:newtab]
[task 2019-11-23T15:21:35.427Z] 15:21:35 INFO - GECKO(8991) | --DOCSHELL 0x7f18f1804800 == 1 [pid = 9152] [id = {07ab985f-6ed1-420e-a5c3-b2e1d9a2a69a}] [url = about:blank]
[task 2019-11-23T15:21:35.493Z] 15:21:35 INFO - TEST-INFO | started process screentopng
[task 2019-11-23T15:21:36.157Z] 15:21:36 INFO - TEST-INFO | screentopng: exit 0
[task 2019-11-23T15:21:36.158Z] 15:21:36 INFO - Buffered messages logged at 15:21:34
[task 2019-11-23T15:21:36.159Z] 15:21:36 INFO - Entering test bound test_render_hardcoded
[task 2019-11-23T15:21:36.159Z] 15:21:36 INFO - Console message: [JavaScript Error: "Failed to fetch https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=&locale_lang=en-US&count=30: Not one of allowed prefixes (data:)" {file: "resource://activity-stream/lib/DiscoveryStreamFeed.jsm" line: 245}]
[task 2019-11-23T15:21:36.159Z] 15:21:36 INFO - fetchFromEndpoint@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:245:10
[task 2019-11-23T15:21:36.160Z] 15:21:36 INFO - getComponentFeed@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:970:39
[task 2019-11-23T15:21:36.161Z] 15:21:36 INFO - asyncbuildFeedPromise/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:428:34
[task 2019-11-23T15:21:36.161Z] 15:21:36 INFO - reduceFeedComponents/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:500:10
[task 2019-11-23T15:21:36.161Z] 15:21:36 INFO - buildFeedPromises@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:520:8
[task 2019-11-23T15:21:36.162Z] 15:21:36 INFO - loadComponentFeeds@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:534:49
[task 2019-11-23T15:21:36.163Z] 15:21:36 INFO - refreshAll@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1039:12
[task 2019-11-23T15:21:36.164Z] 15:21:36 INFO - async
enable@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1161:16
[task 2019-11-23T15:21:36.165Z] 15:21:36 INFO - asynconPrefChange@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1207:18
[task 2019-11-23T15:21:36.165Z] 15:21:36 INFO - async
onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1337:20
[task 2019-11-23T15:21:36.165Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.166Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.167Z] 15:21:36 INFO - onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1452:24
[task 2019-11-23T15:21:36.167Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.167Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.167Z] 15:21:36 INFO - onPrefChanged@resource://activity-stream/lib/PrefsFeed.jsm:35:18
[task 2019-11-23T15:21:36.168Z] 15:21:36 INFO - observer@resource://activity-stream/lib/ActivityStreamPrefs.jsm:33:16
[task 2019-11-23T15:21:36.168Z] 15:21:36 INFO - _setPref@resource://specialpowers/SpecialPowersParent.jsm:520:31
[task 2019-11-23T15:21:36.169Z] 15:21:36 INFO - _applyPrefs@resource://specialpowers/SpecialPowersParent.jsm:406:14
[task 2019-11-23T15:21:36.170Z] 15:21:36 INFO - pushPrefEnv/<@resource://specialpowers/SpecialPowersParent.jsm:492:12
[task 2019-11-23T15:21:36.172Z] 15:21:36 INFO - doPrefEnvOp@resource://specialpowers/SpecialPowersParent.jsm:65:12
[task 2019-11-23T15:21:36.173Z] 15:21:36 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersParent.jsm:437:12
[task 2019-11-23T15:21:36.173Z] 15:21:36 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:645:21
[task 2019-11-23T15:21:36.174Z] 15:21:36 INFO -
[task 2019-11-23T15:21:36.180Z] 15:21:36 INFO - Console message: [JavaScript Error: "No response for feed" {file: "resource://activity-stream/lib/DiscoveryStreamFeed.jsm" line: 987}]
[task 2019-11-23T15:21:36.181Z] 15:21:36 INFO - getComponentFeed@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:987:12
[task 2019-11-23T15:21:36.181Z] 15:21:36 INFO - asyncbuildFeedPromise/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:428:34[task 2019-11-23T15:21:36.182Z] 15:21:36 INFO - reduceFeedComponents/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:500:10
[task 2019-11-23T15:21:36.183Z] 15:21:36 INFO - buildFeedPromises@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:520:8
[task 2019-11-23T15:21:36.183Z] 15:21:36 INFO - loadComponentFeeds@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:534:49
[task 2019-11-23T15:21:36.184Z] 15:21:36 INFO - refreshAll@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1039:12
[task 2019-11-23T15:21:36.184Z] 15:21:36 INFO - async
enable@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1161:16
[task 2019-11-23T15:21:36.185Z] 15:21:36 INFO - asynconPrefChange@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1207:18
[task 2019-11-23T15:21:36.186Z] 15:21:36 INFO - async
onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1337:20
[task 2019-11-23T15:21:36.186Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.187Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.188Z] 15:21:36 INFO - onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1452:24
[task 2019-11-23T15:21:36.188Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.188Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.189Z] 15:21:36 INFO - onPrefChanged@resource://activity-stream/lib/PrefsFeed.jsm:35:18
[task 2019-11-23T15:21:36.190Z] 15:21:36 INFO - observer@resource://activity-stream/lib/ActivityStreamPrefs.jsm:33:16
[task 2019-11-23T15:21:36.190Z] 15:21:36 INFO - _setPref@resource://specialpowers/SpecialPowersParent.jsm:520:31
[task 2019-11-23T15:21:36.191Z] 15:21:36 INFO - _applyPrefs@resource://specialpowers/SpecialPowersParent.jsm:406:14
[task 2019-11-23T15:21:36.191Z] 15:21:36 INFO - pushPrefEnv/<@resource://specialpowers/SpecialPowersParent.jsm:492:12
[task 2019-11-23T15:21:36.192Z] 15:21:36 INFO - doPrefEnvOp@resource://specialpowers/SpecialPowersParent.jsm:65:12
[task 2019-11-23T15:21:36.192Z] 15:21:36 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersParent.jsm:437:12
[task 2019-11-23T15:21:36.192Z] 15:21:36 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:645:21
[task 2019-11-23T15:21:36.193Z] 15:21:36 INFO -
[task 2019-11-23T15:21:36.194Z] 15:21:36 INFO - Console message: [JavaScript Error: "Error trying to load component feed https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=$locale&count=30: TypeError: settings is undefined" {file: "resource://activity-stream/lib/DiscoveryStreamFeed.jsm" line: 458}]
[task 2019-11-23T15:21:36.194Z] 15:21:36 INFO - buildFeedPromise/</<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:458:18
[task 2019-11-23T15:21:36.194Z] 15:21:36 INFO -
[task 2019-11-23T15:21:36.195Z] 15:21:36 INFO - Console message: [JavaScript Error: "Failed to fetch https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=&locale_lang=en-US&count=30: Not one of allowed prefixes (data:)" {file: "resource://activity-stream/lib/DiscoveryStreamFeed.jsm" line: 245}]
[task 2019-11-23T15:21:36.195Z] 15:21:36 INFO - fetchFromEndpoint@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:245:10
[task 2019-11-23T15:21:36.195Z] 15:21:36 INFO - getComponentFeed@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:970:39
[task 2019-11-23T15:21:36.195Z] 15:21:36 INFO - asyncbuildFeedPromise/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:428:34
[task 2019-11-23T15:21:36.196Z] 15:21:36 INFO - reduceFeedComponents/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:500:10
[task 2019-11-23T15:21:36.196Z] 15:21:36 INFO - buildFeedPromises@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:520:8
[task 2019-11-23T15:21:36.197Z] 15:21:36 INFO - loadComponentFeeds@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:534:49
[task 2019-11-23T15:21:36.197Z] 15:21:36 INFO - _maybeUpdateCachedData@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1014:18
[task 2019-11-23T15:21:36.198Z] 15:21:36 INFO - async
refreshAll@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1044:18
[task 2019-11-23T15:21:36.198Z] 15:21:36 INFO - asyncenable@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1161:16
[task 2019-11-23T15:21:36.198Z] 15:21:36 INFO - async
onPrefChange@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1207:18
[task 2019-11-23T15:21:36.199Z] 15:21:36 INFO - asynconAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1337:20
[task 2019-11-23T15:21:36.204Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.204Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.205Z] 15:21:36 INFO - onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1452:24[task 2019-11-23T15:21:36.206Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.208Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.208Z] 15:21:36 INFO - onPrefChanged@resource://activity-stream/lib/PrefsFeed.jsm:35:18
[task 2019-11-23T15:21:36.209Z] 15:21:36 INFO - observer@resource://activity-stream/lib/ActivityStreamPrefs.jsm:33:16
[task 2019-11-23T15:21:36.209Z] 15:21:36 INFO - _setPref@resource://specialpowers/SpecialPowersParent.jsm:520:31
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - _applyPrefs@resource://specialpowers/SpecialPowersParent.jsm:406:14
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - pushPrefEnv/<@resource://specialpowers/SpecialPowersParent.jsm:492:12
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - doPrefEnvOp@resource://specialpowers/SpecialPowersParent.jsm:65:12
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersParent.jsm:437:12
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:645:21
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO -
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - Console message: [JavaScript Error: "No response for feed" {file: "resource://activity-stream/lib/DiscoveryStreamFeed.jsm" line: 987}]
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - getComponentFeed@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:987:12
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - async
buildFeedPromise/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:428:34
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - reduceFeedComponents/<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:500:10
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - buildFeedPromises@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:520:8
[task 2019-11-23T15:21:36.213Z] 15:21:36 INFO - loadComponentFeeds@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:534:49
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - _maybeUpdateCachedData@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1014:18
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - asyncrefreshAll@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1044:18
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - async
enable@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1161:16
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - asynconPrefChange@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1207:18
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - async
onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1337:20
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - onAction@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:1452:24
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - _middleware/</<@resource://activity-stream/lib/Store.jsm:63:17
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - Store/this[method]@resource://activity-stream/lib/Store.jsm:39:54
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - onPrefChanged@resource://activity-stream/lib/PrefsFeed.jsm:35:18
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - observer@resource://activity-stream/lib/ActivityStreamPrefs.jsm:33:16
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - _setPref@resource://specialpowers/SpecialPowersParent.jsm:520:31
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - _applyPrefs@resource://specialpowers/SpecialPowersParent.jsm:406:14
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - pushPrefEnv/<@resource://specialpowers/SpecialPowersParent.jsm:492:12
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - doPrefEnvOp@resource://specialpowers/SpecialPowersParent.jsm:65:12
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - pushPrefEnv@resource://specialpowers/SpecialPowersParent.jsm:437:12
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:645:21
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - [task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - Console message: [JavaScript Error: "Error trying to load component feed https://getpocket.cdn.mozilla.net/v3/firefox/global-recs?version=3&consumer_key=$apiKey&locale_lang=$locale&count=30: TypeError: settings is undefined" {file: "resource://activity-stream/lib/DiscoveryStreamFeed.jsm" line: 458}]
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - buildFeedPromise/</<@resource://activity-stream/lib/DiscoveryStreamFeed.jsm:458:18
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO -
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - Buffered messages logged at 15:21:35
[task 2019-11-23T15:21:36.214Z] 15:21:36 INFO - TEST-PASS | browser/components/newtab/test/browser/browser_discovery_render.js | Got the discovery stream top sites section - {} == true -
[task 2019-11-23T15:21:36.216Z] 15:21:36 INFO - Buffered messages finished
[task 2019-11-23T15:21:36.216Z] 15:21:36 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_discovery_render.js | Got the rendered Message with link text and url within discovery stream - "" == "What’s Pocket?" -

The export included Bug 1567273 - Enable DE using Discovery Stream (#5367) https://github.com/mozilla/activity-stream/commit/9ef5e8f837958eea6408f1589209f6821ecde53c

That touched the "What's Pocket?" string

Flags: needinfo?(edilee) → needinfo?(sdowne)

When I try to run that test locally, the test suite times out on "0:01.40 GECKO(5920) BG_observe@BrowserGlue.jsm:814:1"`

So far all I've got is that string went from hard coded to fluent during the above export. I suspect because of fluent, maybe the string isn't replaced yet?

Flags: needinfo?(sdowne)

FWIW running mach test discovery_render locally with latest MC and AS code exited 0. Tried about 10 times, no whammies.

If I let it run until it times out, I see:

Traceback (most recent call last):
  File "/home/scott/mozilla-central/objdir-frontend/_tests/testing/mochitest/runtests.py", line 2874, in doTests
    e10s=options.e10s
  File "/home/scott/mozilla-central/objdir-frontend/_tests/testing/mochitest/runtests.py", line 2369, in runApp
    raise exc(value).with_traceback(tb)
AttributeError: 'timeout' object has no attribute 'with_traceback'
 2:00.68 ERROR Automation Error: Received unexpected exception while running application

That test is just waiting for Top Sites to render, so seems like a race condition. Just made a PR to make it wait for the anchor it's testing specifically.

So I've got my test running locally. I've tried a bunch of things, and I cannot seem to get it to fail locally either. I've been running it like so ./mach test browser_discovery_render.js --repeat=100 Even tried it on 300 a few times.

It def feels like a race condition, but I don't understand it much. Nothing about the changes in the pr would cause a race condition. My only theory is the race condition was always there, but because the string was hard coded, it was always fast enough to win the race. Now that the string is fluent, it's a bit slower? thus now sometimes doesn't win.

If that's the case, I think Gavin's patch is going help by making the test wait for a different condition.

Is there a way though to wait until fluent is done?

Another idea is we no longer have our test look at a string that's fluent based as the finish condition, maybe just the existence of a css clas? It's not testing fluent so I don't see the need to use fluent as the condition.

In the last 7 days there have been 21 occurrences on linux 64 and macosx1014-64, build types mostly debug and some asan.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279901781&repo=autoland&lineNumber=17314

Assignee: nobody → sdowne
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: