1598968 - MediaControlUtils.h contains headers and symbols, leading to a failed linking process when used elsewhere

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P3)

Description

[Marc Streckfuß [:MeFisto94]]

So, as suggested on https://phabricator.services.mozilla.com/D47999#1575254 and later comments, I wanted to use the gMediaControlLog.

This however didn't work as MediaControlUtils.h didn't only contain Declarations but also Definitions. Thinking this is an oversight, I was preparing to move gMediaControlLog into MediaController, but the build failed again due to the methods in said file.

Is there any particular reason this Header-File Contains code? Or should this file be renamed to .cpp and should an appropriate header be added?

Comment 1

[Alastor Wu [:alwu]]

Could you try to rebase your patches onto the latest codebase? I believe this issue have been fixed, because we have removed the use of MediaUtils from the outer window.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

That still doesn't change the fact that MediaControlUtils.h cannot be included in two different cpp files, right?

Comment 3

[Alastor Wu [:alwu]]

No, it can [1], but I don't understand why including it on the outer window would cause that issue, maybe involving with compling order?

[1] https://searchfox.org/mozilla-central/search?q=MediaControlUtils.h&path=

Comment 4

[Emilio Cobos Álvarez [:emilio]]

No, the issue is that those files get pulled into the same translation unit, so it doesn't get included multiple times. If you include it anywhere else in the project, it will file, as it defines the logger and other functions that are not marked as inline.

Does that make sense? :)

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Well I'll just fix this, hopefully the patch makes the problem obvious.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1598968 - Make MediaControlUtils a proper header. r=Mefisto94!,alwu!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3886adb1a5e2
Make MediaControlUtils a proper header. r=MeFisto94,alwu

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3886adb1a5e2